roachtest: use n1-standard for 16-core GCE machines #88346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Typo, should be |
srosenberg
approved these changes
Sep 21, 2022
Roachtest used `n1-highcpu` machines at 16 cores and beyond. However, this causes a memory cliff, because a `n1-standard-8` machine has ~30 GB memory (3.75 GB per core), but a `n1-highcpu-16` machine only has 14 GB memory (0.9 GB per core). This patch makes 16-core machines use `n1-standard` as well, with 60 GB memory, and only switches to `n1-highcpu` at 32 cores (with 29 GB memory). Release note: None
erikgrinaker
force-pushed
the
roachtest-16cpu
branch
from
ed62b64 to
c7f231b
Compare
Yep, thanks! bors r=srosenberg |
|
Build succeeded: |
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roachtest used
n1-highcpumachines at 16 cores and beyond. However, this causes a memory cliff, because an1-standard-8machine has ~30 GB memory (3.75 GB per core), but an1-highcpu-16machine only has 14 GB memory (0.9 GB per core).This patch makes 16-core machines use
n1-standardas well, with 60 GB memory, and only switches ton1-highcpuat 32 cores (with 29 GB memory).Touches #87809.
Release note: None