tenantrate: deflake testcloser #88303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Sep 20, 2022
This patch increases the request size in `TestCloser` in order to jam the request, to assert on timers closing. An earlier patch lowered the RU cost below the burst threshold, making it so that this request never waited. The test previously flaked after 1 run. `53538 runs so far, 0 failures, over 2m5s` resolves: cockroachdb#86822 Release note: None
kvoli
force-pushed
the
220920.tenantrate-deflake
branch
from
1abc442 to
e59cbad
Compare
|
bors r=irfansharif |
|
Build succeeded: |
This was referenced Sep 21, 2022
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this pull request
Mar 3, 2023
I'm blindly applying the technique from cockroachdb#88303 since I am unable to reproduce this on mac or linux myself. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch increases the request size in
TestCloserin order to jam the request, to assert on timers closing. An earlier patch lowered the RU cost below the burst threshold, making it so that this request never waited.The test previously flaked after 1 run.
53538 runs so far, 0 failures, over 2m5sresolves: #86822
Release note: None