-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv/kvserver/tenantrate: TestCloser
is flakey
#86822
Comments
Off of latest master.
|
Refs: cockroachdb#86822 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None
86825: kv/kvserver/tenantrate: skip TestCloser r=irfansharif a=irfansharif Refs: #86822 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None Co-authored-by: irfan sharif <[email protected]>
Huh, ok repros on linux. Bisecting. |
On my GCE worker I trip things up as far back as 05bc43d using |
Bisecting took me conclusively to 61674bc (+cc @andy-kimball). Triple checked running the preceding commit and that one. I'll keep this on the KV plate for now to get to during stability. I'm not sure why this only starting firing in CI now but it should be easy to fix. |
Refs: #86822 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None
It looks like the update to RU accounting made it such that the request that was meant to hit a try again/retry timer in this test, doesn't. The configured limit for the test:
The request is around The updated accounting made this req cheaper I believe. Pushing the req to double the size |
88303: tenantrate: deflake testcloser r=irfansharif a=kvoli This patch increases the request size in `TestCloser` in order to jam the request, to assert on timers closing. An earlier patch lowered the RU cost below the burst threshold, making it so that this request never waited. The test previously flaked after 1 run. `53538 runs so far, 0 failures, over 2m5s` resolves: #86822 Release note: None Co-authored-by: Austen McClernon <[email protected]>
This patch increases the request size in `TestCloser` in order to jam the request, to assert on timers closing. An earlier patch lowered the RU cost below the burst threshold, making it so that this request never waited. The test previously flaked after 1 run. `53538 runs so far, 0 failures, over 2m5s` resolves: #86822 Release note: None
This patch increases the request size in `TestCloser` in order to jam the request, to assert on timers closing. An earlier patch lowered the RU cost below the burst threshold, making it so that this request never waited. The test previously flaked after 1 run. `53538 runs so far, 0 failures, over 2m5s` resolves: #86822 Release note: None
Describe the problem
Please describe the issue you observed, and any steps we can take to reproduce it:
https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests_BazelUnitTests/6228580?showRootCauses=false&expandBuildChangesSection=true
Jira issue: CRDB-18947
The text was updated successfully, but these errors were encountered: