Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: ui: remove link to stmt details when already on the page #87800

Merged
merged 2 commits into from
Sep 12, 2022
Merged

release-22.2: ui: remove link to stmt details when already on the page #87800

merged 2 commits into from
Sep 12, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 11, 2022 •
edited by mdlinville
Loading

Backport 2/2 commits from #87766 on behalf of @maryliag.

/cc @cockroachdb/release

Previously, the insights on statement details for
index recommendation had a link for the statement details page,
which was not doing anything since the user was already on the page.
If they refresh using the link it was showing wrong aggregation.
This commit removes the link when the insights is on the statement page already,
but keeps the link when the insight is on the schema insights page.

Fixes #87752

https://www.loom.com/share/8fb0f6e8d7ca4d08a19e52d3a5701a43

Release note (ui change): The Insight Statement Detail page is linked from the Insight Statement page but no longer includes a link to itself.

Release justification: bug fix

@maryliag
ui: change the unkown insight to the proper slow execution
6774169 
Previously, when we didn't have a reason to why the
statement was slow, we were showing a message about unable
to identify the problem.
Since we do know it was slow, this commit changes it
to the proper message about the statement being slow.
This commit also adds a link to cluster settings
documentation to all insights that are dependent on
a cluster setting.
The value for the cluster setting is being added
in another issue: #86760

Fixes #87740

Release note (ui change): Improve message when there
is no insight problem detected. Now we show the statement
was slow and how long it took.
@maryliag
ui: remove link to stmt details when already on the page
9593fd8 
Previously, the insights on statement details for
index recommendation had a link for the statement details
page, which was not doing anything since the user was
already on the page. If they refresh using the link it
was showing wrong aggregation.
This commit removes the link when the insights is on
the statement page already, but keeps the link when
the insight is on the schema insights page.

Fixes #87752

Release note (ui change): Removal of the link on
insights pointing to Statement Details page when
it was already on the Statement Details page.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-87766 branch from 8541e4a to 9593fd8 Compare September 11, 2022 21:04
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 11, 2022 •
edited by maryliag
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from matthewtodd September 11, 2022 21:04
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 11, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from a team September 12, 2022 13:08
THardy98
THardy98 approved these changes Sep 12, 2022
View reviewed changes
Copy link

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryliag maryliag merged commit 9b7bb0d into release-22.2 Sep 12, 2022
@maryliag maryliag deleted the blathers/backport-release-22.2-87766 branch September 12, 2022 13:20
@nickvigilante nickvigilante mentioned this pull request Sep 14, 2022
Closed
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THardy98 THardy98 THardy98 approved these changes

@matthewtodd matthewtodd Awaiting requested review from matthewtodd

Assignees

@maryliag maryliag

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @THardy98 @maryliag