Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance testing 22.2 - Aggregation and URL issues on the EXPLAIN plan tab #87752

Closed
kevin-v-ngo opened this issue Sep 9, 2022 · 0 comments · Fixed by #87766
Closed

Acceptance testing 22.2 - Aggregation and URL issues on the EXPLAIN plan tab #87752

kevin-v-ngo opened this issue Sep 9, 2022 · 0 comments · Fixed by #87766
Assignees
@maryliag
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented Sep 9, 2022 •
edited
Loading

  1. Create two statement fingerprints (implicit and explicit) that have the same plan gist and recommendation
  2. Navigate to the explain tab for one of the fingerprint and click on the fingerprint URL in the insights details section
  3. URL is broken (we should remove the URL in this view since the user is already on the fingerprint details page)
  4. Refresh the page
  5. Fingerprint aggregation stats are different (based on both fingerprints?)

Loom recording: https://www.loom.com/share/537836dc7d8a41388e7d2936e08db576

Jira issue: CRDB-19514
@kevin-v-ngo kevin-v-ngo added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 9, 2022
@maryliag maryliag self-assigned this Sep 10, 2022
@maryliag maryliag mentioned this issue Sep 10, 2022
Merged
craig bot pushed a commit that referenced this issue Sep 11, 2022
@maryliag
Merge #87766
773568f 
87766: ui: remove link to stmt details when already on the page r=maryliag a=maryliag

Previously, the insights on statement details for
index recommendation had a link for the statement details page, 
which was not doing anything since the user was already on the page. 
If they refresh using the link it was showing wrong aggregation.
This commit removes the link when the insights is on the statement page already, 
but keeps the link when the insight is on the schema insights page.

Fixes #87752

https://www.loom.com/share/8fb0f6e8d7ca4d08a19e52d3a5701a43

Release note (ui change): Removal of the link on
insights pointing to Statement Details page when
it was already on the Statement Details page.

Co-authored-by: Marylia Gutierrez <[email protected]>
@craig craig bot closed this as completed in 03d9d7f Sep 11, 2022
blathers-crl bot pushed a commit that referenced this issue Sep 11, 2022
@maryliag
ui: remove link to stmt details when already on the page
9593fd8 
Previously, the insights on statement details for
index recommendation had a link for the statement details
page, which was not doing anything since the user was
already on the page. If they refresh using the link it
was showing wrong aggregation.
This commit removes the link when the insights is on
the statement page already, but keeps the link when
the insight is on the schema insights page.

Fixes #87752

Release note (ui change): Removal of the link on
insights pointing to Statement Details page when
it was already on the Statement Details page.
@blathers-crl blathers-crl bot mentioned this issue Sep 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: remove link to stmt details when already on the page maryliag/cockroach
2 participants
@maryliag @kevin-v-ngo