Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: backupccl: deflake backup tests #87734

Merged
merged 5 commits into from
Sep 16, 2022
Merged

release-22.2: backupccl: deflake backup tests #87734

merged 5 commits into from
Sep 16, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 9, 2022 •
edited by adityamaru
Loading

Backport 5/5 commits from #87646 on behalf of @adityamaru.

/cc @cockroachdb/release

See individual commits.

Release note: None

Release justification: low risk test only change

@adityamaru
importer: deflake TestImportWorkerFailure
53ebb20 
Release note: None

Fixes: #73546
@adityamaru
backupccl: unskip TestBackupWorkerFailure
125d370 
Stressed for 7+ mins without failure.

Release note: None
@adityamaru
backupccl: unskip TestBackupRestoreAppend
b566415 
The test was rather hard to follow because of all the different
flavours of backup we were trying to test. This change removes the
deprecated `BACKUP TO` statements, and also removes the
`BACKUP INTO subdir IN dir` testcase that is no longer a query
we allow users to run.

Fixes: #54599

Release note: None
@adityamaru
backupccl: delete skipped TestSpanSelectionDuringBackup
1eecfd0 
This test is unweildy and not testing anything that `TestPublicIndexTableSpans`
isn't. Coordinating GC and running backups is heavy handed for what we want
to test and `TestPublicIndexTableSpans` offers adequate coverage that we can
get rid of this.

Fixes: #63209

Release note: None
@adityamaru
backupccl: unskip TestGCDropIndexSpanExpansion
08e7d1a 
Ran this under stressrace, stress and race and haven't seen
a single failure.

Fixes: #77569

Release note: None
@blathers-crl blathers-crl bot requested review from a team and dt September 9, 2022 19:16
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-87646 branch from ac117a9 to 08e7d1a Compare September 9, 2022 19:16
@blathers-crl blathers-crl bot requested a review from msbutler September 9, 2022 19:16
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 9, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 9, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru adityamaru merged commit df3b40f into release-22.2 Sep 16, 2022
@adityamaru adityamaru deleted the blathers/backport-release-22.2-87646 branch September 16, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt dt dt approved these changes

@msbutler msbutler Awaiting requested review from msbutler

Assignees

@adityamaru adityamaru

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @dt @adityamaru