backupccl: deflake backup tests #87646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None Fixes: cockroachdb#73546
Stressed for 7+ mins without failure. Release note: None
The test was rather hard to follow because of all the different flavours of backup we were trying to test. This change removes the deprecated `BACKUP TO` statements, and also removes the `BACKUP INTO subdir IN dir` testcase that is no longer a query we allow users to run. Fixes: cockroachdb#54599 Release note: None
This test is unweildy and not testing anything that `TestPublicIndexTableSpans` isn't. Coordinating GC and running backups is heavy handed for what we want to test and `TestPublicIndexTableSpans` offers adequate coverage that we can get rid of this. Fixes: cockroachdb#63209 Release note: None
Ran this under stressrace, stress and race and haven't seen a single failure. Fixes: cockroachdb#77569 Release note: None
|
This change is |
msbutler
approved these changes
Sep 8, 2022
|
I've been using https://roachdash.crdb.dev/?filter=status%3Aopen+l%3Askipped-test+*skipped+r%3Acockroachdb%2Fcockroach&group=project&sort=-lastcommented&restgroup=true&display=project+category+lastorigin+lastcommented to find skipped test. There are a few more left which we should be able to see more clearly once all these issues close. bors r=msbutler |
|
Build failed: |
|
heh, didn't realize roachdash existed. |
|
bors r+ |
|
Build succeeded: |
|
blathers backport release-22.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Release note: None