kvserver: explain our use of (*raftGroup).ReportSnapshot #87702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Closes cockroachdb#87581. Release note: None
tbg
force-pushed
the
raft-snap-comment
branch
from
e84dea2 to
b34ef27
Compare
|
PS happy to accept extra commits to this PR with |
andrewbaptist
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @tbg)
|
bors r=andrewbaptist |
|
Build succeeded: |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Sep 19, 2022
Suggested by Nathan[^1]. [^1]: cockroachdb#87702 (comment) Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
88129: opt: copy ColSet in CreateLocalityOptimizedLookupJoinPrivateIncludingCols r=mgartner a=mgartner `CreateLocalityOptimizedLookupJoinPrivateIncludingCols` was mutating a `opt.ColSet` field of another `LookupJoinPrivate` because it was calling `ColSet.UnionWith` without copying the `ColSet` first. This commit fixes the bug. Fixes #88126 Release note: None 88130: changefeedccl: avoid concurrent map access r=[miretskiy] a=HonoreDB go 1.18 introduced more stringent checks for unsafe concurrent map use, surfacing some new and exciting panics in changefeed code. When backported, fixes #87939 When backported, fixes #88089 When backported, fixes #87899 Release note (bug fix): Fixed crashes in changefeed code when running on recent go versions. 88134: kvserver: tweak a comment about raft snaps r=nvanbenschoten a=tbg Suggested by Nathan[^1]. [^1]: #87702 (comment) Release note: None Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: Aaron Zinger <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87581.
Release note: None