opt: copy ColSet in CreateLocalityOptimizedLookupJoinPrivateIncludingCols #88129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This bug is only present on master and release-22.2. |
…Cols `CreateLocalityOptimizedLookupJoinPrivateIncludingCols` was mutating a `opt.ColSet` field of another `LookupJoinPrivate` because it was calling `ColSet.UnionWith` without copying the `ColSet` first. This commit fixes the bug. Fixes cockroachdb#88126 Release note: None
mgartner
force-pushed
the
88126-fix-los-colset-copy
branch
from
ded19fe to
67f18b3
Compare
mgartner
changed the title
michae2
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msirek and @rytaft)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateLocalityOptimizedLookupJoinPrivateIncludingColswas mutating aopt.ColSetfield of anotherLookupJoinPrivatebecause it was callingColSet.UnionWithwithout copying theColSetfirst. This commit fixesthe bug.
Fixes #88126
Release note: None