Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: don't show password in \c metacommand #87298

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Sep 1, 2022

fixes #87294

Release note (cli change): The \c metacommand no longer shows the
password in plaintext.

Release justification: low risk change

@rafiss rafiss requested a review from a team September 1, 2022 18:27
@rafiss rafiss requested a review from a team as a code owner September 1, 2022 18:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (cli change): The \c metacommand no longer shows the
password in plaintext.

Release justification: low risk change
@rafiss rafiss requested a review from knz September 7, 2022 15:35
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: nice

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

@rafiss
Copy link
Collaborator Author

rafiss commented Sep 7, 2022

tftr!

bors r=knz

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"1 review requesting changes by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@rafiss
Copy link
Collaborator Author

rafiss commented Sep 7, 2022

bors r=knz

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

Build succeeded:

@craig craig bot merged commit 99a9587 into cockroachdb:master Sep 7, 2022
@blathers-crl
Copy link

blathers-crl bot commented Sep 7, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 887e4d9 to blathers/backport-release-21.2-87298: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from 887e4d9 to blathers/backport-release-22.1-87298: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: metacommand \c exposes password in clear text
3 participants