-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterversion,*: remove pre-22.1 cluster versions #86642
clusterversion,*: remove pre-22.1 cluster versions #86642
Conversation
bfbcbf0
to
dc05e1c
Compare
|
dc05e1c
to
0610d7b
Compare
0610d7b
to
ffc0507
Compare
8/30 Update:
|
Beats me, I suspect someone from CDC will know? Looks like the enabling feature of the didn't take for some reason. |
cc @stevendanna could you provide input on the above? |
This is a rather important test for BulkIO. I think we need somebody from their team to sign off (@stevendanna being a good choice). |
8/30 Update (from celia): TestChangefeedErrors no longer fails |
d7dde23
to
b32ae3c
Compare
f5f21ce
to
a8bf7e3
Compare
Re 8/30 Update: I've updated the PR to leave the The CI output is a bit vague (Lots of "No pass/skip/fail event found for test"): |
Release justification: bump min supported version Release note: None
a8bf7e3
to
c083eb3
Compare
Hi all - this is now RFAL - thanks! All tests now pass for Bazel Essential CI. Here is code that was removed/tweaked, by team-specific areas:
Thanks! |
Schema-related changes LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema changes , @postamar won the race
Reviewed 1 of 11 files at r1, 1 of 5 files at r2, 2 of 4 files at r3.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @adityamaru, @cucaroach, and @irfansharif)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for bakcupccl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 11 files at r1, 3 of 5 files at r2.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @adityamaru, @cucaroach, @irfansharif, and @jlinder)
TFTRs! bors r=jlinder,benbardin,jbowens,ajwerner |
Build failed (retrying...): |
Build succeeded: |
This PR removes any remaining pre-22.1 gates and bumps the minimum-supported version on master, which is required in order for us to cut any release for 22.2
The cleanup for these version gates was fairly straight-forward, using the guidance from #74270 (comment):
Code removed / adjusted, by team-specific areas:
TestRestoreOldVersions
: removedBinaryVersionOverride
reference to old version (cc @RichardJCai / @cockroachdb/bulk-io )TestVirtualColumnNotAllowedInPkeyBefore22_1
(cc @cockroachdb/sql-schema )TestSetMinVersion
to account for deprecated version gates (cc @cockroachdb/storage )Fixes #80663
Release note: None
Release justification: bump minSupportedVersion