Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/backupccl: skip TestRestoreOldVersions #70155

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Sep 13, 2021

Refs: #70154

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Refs: cockroachdb#70154

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@jbowens jbowens requested review from a team and dt and removed request for a team September 13, 2021 19:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens requested a review from nkodali September 13, 2021 22:34
@ajwerner
Copy link
Contributor

My sense is that we should be marking these flaky tests as release blockers. This test matters quite a bit.

@irfansharif
Copy link
Contributor

@ajwerner we used to chase down all skipped tests during our release process and ask teams to sign off on them ( skipped-test ). Is that something we still do?

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 13, 2021

TFTR!

bors r=irfansharif

@ajwerner
Copy link
Contributor

@ajwerner we used to chase down all skipped tests during our release process and ask teams to sign off on them ( skipped-test ). Is that something we still do?

You tell me?

@craig
Copy link
Contributor

craig bot commented Sep 14, 2021

Build succeeded:

@craig craig bot merged commit 19b1766 into cockroachdb:master Sep 14, 2021
@JuanLeon1
Copy link
Contributor

In theory we no longer chase anyone for the release process. If blockers remain by the SHA deadline, we abandon the release.

@jbowens jbowens deleted the skip-test-TestRestoreOldVersions branch September 14, 2021 12:56
@ajwerner
Copy link
Contributor

In theory we no longer chase anyone for the release process. If blockers remain by the SHA deadline, we abandon the release.

The problem with that is that there's nothing marking these skipped tests as blockers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants