-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/backupccl: skip TestRestoreOldVersions #70155
ccl/backupccl: skip TestRestoreOldVersions #70155
Conversation
Refs: cockroachdb#70154 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None
My sense is that we should be marking these flaky tests as release blockers. This test matters quite a bit. |
@ajwerner we used to chase down all skipped tests during our release process and ask teams to sign off on them ( skipped-test ). Is that something we still do? |
TFTR! bors r=irfansharif |
You tell me? |
Build succeeded: |
In theory we no longer chase anyone for the release process. If blockers remain by the SHA deadline, we abandon the release. |
The problem with that is that there's nothing marking these skipped tests as blockers! |
Refs: #70154
Reason: flaky test
Generated by bin/skip-test.
Release justification: non-production code changes
Release note: None