sql/catalog/typedesc: fix bug which partially hydrated a type

[ajwerner]

In rare cases where we hit an error hydrating the contained type of an
array alias type, we'd populate the name, but not the contents.

Fixes #85376

Release note (bug fix): Fixed a rare bug where errors could occur related
to the use of arrays of enums.

[cockroach-teamcity]

This change is 

[fqazi]

One question below for curiosity.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

---

pkg/sql/catalog/typedesc/type_desc.go line 898 at r1 (raw file):

				elemType := typ.ArrayContents()
				if err := EnsureTypeIsHydrated(ctx, elemType, res); err != nil {
					return err

Does this mean we are also ignoring errors somewhere? Or is it just a side effect of mutating the descriptor and caching?

[ajwerner]

TFTR!

bors r=fqazi

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @fqazi)

---

pkg/sql/catalog/typedesc/type_desc.go line 898 at r1 (raw file):

Previously, fqazi (Faizan Qazi) wrote…

Does this mean we are also ignoring errors somewhere? Or is it just a side effect of mutating the descriptor and caching?

I don't think we were ignoring these errors, no.

[ajwerner]

4352 runs so far, 0 failures, over 1h8m15s whereas before it'd always fail within 1000 runs. I feel good about calling this the fix.

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 6b37080 to blathers/backport-release-21.2-85940: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}