Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test: TestLogic_enums failed #85376

Closed
cockroach-teamcity opened this issue Jul 31, 2022 · 8 comments · Fixed by #85940
Closed

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test: TestLogic_enums failed #85376

cockroach-teamcity opened this issue Jul 31, 2022 · 8 comments · Fixed by #85940
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 31, 2022 •
edited by cockroach-jira-scripts
Loading

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test.TestLogic_enums failed with artifacts on master @ 5fe052748de0406d7cb2c8a1e9230143f54f7534:

=== RUN   TestLogic_enums/regression_63138

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Jira issue: CRDB-18214
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jul 31, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Jul 31, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Aug 1, 2022
@rickystewart rickystewart mentioned this issue Aug 1, 2022
Closed
@cockroach-teamcity cockroach-teamcity mentioned this issue Aug 2, 2022
Closed
@yuzefovich
Copy link
Member

This one is a panic with an enum when serializing the session:

[08:00:48][Run stress] === RUN   TestLogic_enums/regression_63138
[08:00:48][Run stress] panic: runtime error: invalid memory address or nil pointer dereference
[08:00:48][Run stress] [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x18a86fb]
[08:00:48][Run stress] 
[08:00:48][Run stress] goroutine 600684 [running]:
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/types.(*T).SQLString(0xc0099e0840)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/types/pkg/sql/types/types.go:1864 +0x131b
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/types.(*T).SQLString(0xc0099e0240)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/types/pkg/sql/types/types.go:1859 +0xd3c
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatTypeReference(0xc007dc7dc0, {0x645a120, 0xc0099e0240})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_name.go:189 +0x28e
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*AnnotateTypeExpr).Format(0xc00d6858f0, 0xc007dc7dc0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/expr.go:1567 +0xbc
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).formatNodeOrHideConstants(0xc007dc7dc0, {0x6456860, 0xc00d6858f0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/hide_constants.go:46 +0x36d
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatNode(0xc007dc7dc0, {0x6456860, 0xc00d6858f0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:449 +0x3b2
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.exprFmtWithParen(0xc007dc7dc0, {0x64a3f20, 0xc00d6858f0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/expr.go:134 +0x12f
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.binExprFmtWithParenAndSubOp(0xc007dc7dc0, {0x64a4cb0, 0xc009b245a0}, {0x5c3a31f, 0x1}, {0x5c3ac91, 0x3}, {0x64a3f20, 0xc00d6858f0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/expr.go:187 +0xff
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*ComparisonExpr).Format(0xc009b24690, 0xc007dc7dc0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/expr.go:387 +0x37c
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).formatNodeOrHideConstants(0xc007dc7dc0, {0x6456f20, 0xc009b24690})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/hide_constants.go:46 +0x36d
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatNode(0xc007dc7dc0, {0x6456f20, 0xc009b24690})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:449 +0x3b2
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FuncExpr).Format(0xc009275a00, 0xc007dc7dc0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/expr.go:1367 +0x4a5
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).formatNodeOrHideConstants(0xc007dc7dc0, {0x6457bc0, 0xc009275a00})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/hide_constants.go:46 +0x36d
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatNode(0xc007dc7dc0, {0x6457bc0, 0xc009275a00})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:449 +0x3b2
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*SelectExpr).Format(0xc00ad3f2e0, 0xc007dc7dc0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/select.go:183 +0x65
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).formatNodeOrHideConstants(0xc007dc7dc0, {0x64591c0, 0xc00ad3f2e0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/hide_constants.go:46 +0x36d
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatNode(0xc007dc7dc0, {0x64591c0, 0xc00ad3f2e0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:449 +0x3b2
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*SelectExprs).Format(0xc00066e860, 0xc007dc7dc0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/select.go:150 +0xb5
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).formatNodeOrHideConstants(0xc007dc7dc0, {0x64591e0, 0xc00066e860})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/hide_constants.go:46 +0x36d
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatNode(0xc007dc7dc0, {0x64591e0, 0xc00066e860})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:449 +0x3b2
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*SelectClause).Format(0xc00066e820, 0xc007dc7dc0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/select.go:117 +0x27b
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).formatNodeOrHideConstants(0xc007dc7dc0, {0x64591a0, 0xc00066e820})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/hide_constants.go:46 +0x36d
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatNode(0xc007dc7dc0, {0x64591a0, 0xc00066e820})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:449 +0x3b2
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Select).Format(0xc009b248c0, 0xc007dc7dc0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/select.go:56 +0xa7
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).formatNodeOrHideConstants(0xc007dc7dc0, {0x6459180, 0xc009b248c0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/hide_constants.go:46 +0x36d
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*FmtCtx).FormatNode(0xc007dc7dc0, {0x6459180, 0xc009b248c0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:449 +0x3b2
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.AsStringWithFlags({0x6459180, 0xc009b248c0}, 0x0, {0x0, 0x0, 0x0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:587 +0xb0
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.AsString({0x6459180, 0xc009b248c0})
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/format.go:602 +0x3c
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Select).String(0xc009b248c0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/stmt.go:1969 +0x35
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).serialize(_)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:3158 +0xb89
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run.func1()
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1829 +0xe7
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run(0xc006c50a00, {0x6488bd0, 0xc00d685560}, 0xc004561600, 0xc00d685e60, 0x0)
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1844 +0x4b0
[08:00:48][Run stress] github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).initConnEx.func1()
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/internal.go:212 +0xef
[08:00:48][Run stress] created by github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).initConnEx
[08:00:48][Run stress] 	github.com/cockroachdb/cockroach/pkg/sql/internal.go:211 +0x6c5
[08:00:48][Run stress] I220731 08:00:47.961309 1 (gostd) testmain.go:642  [-] 1  Test //pkg/sql/logictest/tests/fakedist-vec-off:fakedist-vec-off_test exited with error code 2
[08:00:48][Run stress] 
[08:00:48][Run stress] 
[08:00:48][Run stress] ERROR: <nil>
[08:00:48][Run stress] 
[08:00:48][Run stress] 5 runs completed, 1 failures, over 26m31s

I think there are two problems here:

  • the fact that we're crashing. This stack trace suggests that we were executing VERIFY INDEX internal query from here during backfill of CREATE INDEX foo ON tab(k) WHERE k = ANY (ARRAY['a', 'a']:::typ2[]). It's not immediately clear what exactly was nil causing the crash under stress, but it has something to do with enums. cc @rafiss @cockroachdb/sql-schema in case some of you know something.
  • the fact that the internal executor is registered with the closed session cache. I think it was an omission and I'll fix that.

The first point mostly looks like the schema issue, so putting it on the corresponding board.

@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Aug 10, 2022
@ajwerner
Copy link
Contributor

What was nil here was the Name of the UDT:

cockroach/pkg/sql/types/types.go

Lines 191 to 192 in ddabd18

// Name is the resolved name of this type.
Name *UserDefinedTypeName

I don't know that we have a proof that the type has been hydrated. I have a feeling that the issue runs a little bit deeper in that maybe we're hydrating the array type but not the contents?

@yuzefovich yuzefovich mentioned this issue Aug 10, 2022
Closed
@ajwerner
Copy link
Contributor

Okay, I did some digging. I think the core problem ends up being here:

cockroach/pkg/sql/sem/tree/type_name.go

Lines 153 to 157 in 9804737

typ, err := ResolveType(ctx, t.ElementType, resolver)
if err != nil {
return nil, err
}
return types.MakeArray(typ), nil

In TypeCheck we call ResolveType and overwrite the reference to the type in the AST to the resolved type. Now, the problem here is that we don't go and resolve the reference type. I think I have a fix I want.

@ajwerner
Copy link
Contributor

Err nevermind that does not make sense.

@yuzefovich
Copy link
Member

@ajwerner do you have an idea for why this diff

diff --git a/pkg/sql/catalog/typedesc/type_desc.go b/pkg/sql/catalog/typedesc/type_desc.go
index 02e77e5a40..08820572d9 100644
--- a/pkg/sql/catalog/typedesc/type_desc.go
+++ b/pkg/sql/catalog/typedesc/type_desc.go
@@ -796,6 +796,9 @@ func EnsureTypeIsHydrated(
                                return err
                        }
                }
+       } else if t.Family() == types.ArrayFamily {
+               // Hydrate the element type.
+               return EnsureTypeIsHydrated(ctx, t.ArrayContents(), res)
        }
        if !t.UserDefined() || t.IsHydrated() {
                return nil
@@ -897,11 +900,7 @@ func (desc *immutable) HydrateTypeInfoWithName(
        case descpb.TypeDescriptor_ALIAS:
                if typ.UserDefined() {
                        switch typ.Family() {
-                       case types.ArrayFamily:
-                               // Hydrate the element type.
-                               elemType := typ.ArrayContents()
-                               return EnsureTypeIsHydrated(ctx, elemType, res)
-                       case types.TupleFamily:
+                       case types.ArrayFamily, types.TupleFamily:
                                return EnsureTypeIsHydrated(ctx, typ, res)
                        default:
                                return errors.AssertionFailedf("unhandled alias type family %s", typ.Family())

would actually break things?

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4d265c5]

goroutine 4573 [running]:
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).recover(0xc00024fdd0, {0x8cee300, 0xc0014a9890})
	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:248 +0xa5
panic({0x7ad82c0, 0xb33daa0})
	GOROOT/src/runtime/panic.go:838 +0x207
github.com/cockroachdb/cockroach/pkg/sql/types.(*T).PGName(0xc003df0240)
	github.com/cockroachdb/cockroach/pkg/sql/types/pkg/sql/types/types.go:1535 +0xc5
github.com/cockroachdb/cockroach/pkg/sql.glob..func109.1({0x8d546e0?, 0xc001779050?}, {0xc002b26588, 0x6}, {0x8d75c48, 0xc003def900})
	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:530 +0xcb3
github.com/cockroachdb/cockroach/pkg/sql.forEachTableDesc.func1({0x8d546e0?, 0xc001779050?}, {0xc002b26588?, 0x6800000069?}, {0x8d75c48?, 0xc003def900?}, 0xc001779050?)
	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2292 +0x37
github.com/cockroachdb/cockroach/pkg/sql.forEachTableDescWithTableLookupInternalFromDescriptors({0x8cee300, 0xc0014a9890}, 0xc00164dc00, {0x8d546e0, 0xc0015d7320}, 0x0, 0x64?, {{{0xc003cb2080}, {0xc003cb2040}, 0xc003952db0}, ...}, ...)
	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2549 +0x518

@ajwerner
Copy link
Contributor

Doesn't your patch fail to actually hydrate the Array type with a name?

@yuzefovich
Copy link
Member

Why do you say so? The patch seems like a noop to me.

@ajwerner
Copy link
Contributor

I solved the mystery! It took way too long :(

The type hydration code short-circuits if the type is already hydrated. The determination as to whether it is hydrated is:

cockroach/pkg/sql/types/types.go

Line 2690 in ddabd18

return t.UserDefined() && t.TypeMeta != (UserDefinedTypeMetadata{})

You'll notice that we populate some of these fields, and then proceed to try to hydrate the array contents, which can fail.

cockroach/pkg/sql/catalog/typedesc/type_desc.go

Lines 882 to 887 in 8a9ebff

ExplicitSchema: name.ExplicitSchema,
Schema: name.Schema(),
Name: name.Object(),
}
typ.TypeMeta.Version = uint32(desc.Version)
switch desc.Kind {

If we do fail to hydrate the array contents, then we'll be in a bad state.

#85940

@ajwerner ajwerner mentioned this issue Aug 11, 2022
Merged
@craig craig bot closed this as completed in 47dfddf Aug 11, 2022
@blathers-crl blathers-crl bot mentioned this issue Aug 11, 2022
Merged
rickystewart added a commit to rickystewart/cockroach that referenced this issue Aug 30, 2022
@rickystewart
github-post: allow for finding the test in a parent directory of the pkg
f9f1722 
In some cases the Bazel test runner "incorrectly" reports the package
path for tests. For example, we have [issues](cockroachdb#85376) where the name of
the test is reported as `pkg/.../package/package_test` rather than
`pkg/.../package` as we might expect. I suspect this is confusing
`github-post` when it tries to find tests in the `package_test`
directory rather than the `package` directory.

We address this by allowing `github-post` to search up the directory
tree for the test rather than expecting it to be in one particular
directory.

Also update a repro command to use `dev test` rather than
`make stressrace`.

Closes cockroachdb#85420.

Release justification: Non-production code changes
Release note: None
rickystewart added a commit to rickystewart/cockroach that referenced this issue Aug 31, 2022
@rickystewart
github-post: allow for finding the test in a parent directory of the pkg
c4e95f0 
In some cases the Bazel test runner "incorrectly" reports the package
path for tests. For example, we have [issues](cockroachdb#85376) where the name of
the test is reported as `pkg/.../package/package_test` rather than
`pkg/.../package` as we might expect. I suspect this is confusing
`github-post` when it tries to find tests in the `package_test`
directory rather than the `package` directory.

We address this by allowing `github-post` to search up the directory
tree for the test rather than expecting it to be in one particular
directory.

Also update a repro command to use `dev test` rather than
`make stressrace`.

Closes cockroachdb#85420.

Release justification: Non-production code changes
Release note: None
craig bot pushed a commit that referenced this issue Aug 31, 2022
@wenyihu6 @kvoli
@e-mbrown @ericharmeling @sjbarag @yuzefovich @maryliag @rickystewart
Merge #85354 #86592 #87024 #87110 #87135 #87149 #87153 #87155 #87156 #…
0bcbece 
…87158

85354: sql: notices for NotVisible Indexes r=wenyihu6 a=wenyihu6

Optimizer now supports creating invisible indexes after this
[PR](#85794). An important use case
for not visible indexes is to test the behaviour of dropping an index by marking
the index invisible. However, there are certain cases where users cannot expect
dropping an index to behave exactly the same as marking an index invisible. More
specifically, NotVisible indexes may still be used to police unique or foreign
key constraint check behind the scene. In those cases, dropping the index might
behave different from marking the index invisible. Prior to this commit, users
do not know about this without reading the documentation. This commit adds some
user-friendly notices when users are dropping or changing a not visible index
that might be helpful for constraint check.

There are two cases where we are giving this notice: 1. if this index is unique.
2. if this index is on child table and may help with FK check.

More details on how this decision was made in
docs/RFCS/20220628_invisible_index.md.

Assists: #72576

See also: #85794

Release justification: low risk to the existing functionality; this commit just
adds notices.

Release note: none

86592: kvserver: rework memory allocation in replicastats r=kvoli a=kvoli

This patch removes some unused fields within the replica stats object.
It also opts to allocate all the memory needed upfront for a replica
stats object for better cache locality and less GC overhead.

This patch also removes locality tracking for the other throughput trackers
to reduce per-replica memory footprint.

resolves #85112

Release justification: low risk, lowers memory footprint to avoid oom.
Release note: None

87024: sql: Prevent primary region being same as secondary region r=rafiss a=e-mbrown

fixes #86879

We found that the primary region could be assigned the same region as the secondary region. This commit adds an error to prevent that.

Release justification: Low risk high benefit change to existing functionality
Release note: None

87110: ui: fixes to high contention copy in insight workload pages r=ericharmeling a=ericharmeling

Previously, the High Contention insight type was labeled
"High Contention Time", and the waiting transactions list
was labeled in the incorrect tense. This commit fixes those
typos.

Release justification: bug fix
Release note: None

87135: build: remove newly-added node_modules/ trees in ui-maintainer-clean r=rickystewart a=sjbarag

A few recent features [1, 2] introduced new node_modules/ trees for
dependencies, but didn't update the ui-maintainer-clean Make target to
remove them. This allowed those directories to leak between TeamCity
builds with Docker user permissions, preventing a `yarn install` in
those packages from properly laying out a `node_modules/.bin` directory
for executables like `tsc`. Remove the recently-introduced
`node_modules/` directories as part of `make ui-maintainer-clean`, to
restore a clean state between jobs.

[1] d28c072 (ui: add eslint-plugin-crdb package with custom eslint rules, 2022-05-27)
[2] c58279d (ui: reintroduce end-to-end UI tests with cypress, 2022-08-12)

Release justification: Non-production code changes

87149: sql: clean up physical planning for system tenant r=yuzefovich a=yuzefovich

This commit audits a couple of methods around the health and version of
DistSQL nodes that are used only for the system tenant to make that more
explicit. Additionally, it unexports `NodeStatuses` map from the
planning context as well as removes some unnecessary short-circuiting
behavior around checking the node health and version (it was unnecessary
because we already short-circuit in
`checkInstanceHealthAndVersionSystem`).

Release justification: low-risk cleanup.

Release note: None

87153: ui: ux improvements on stmt details page r=maryliag a=maryliag

This commit adds a few improvements and bug fixes:

- Handles the case where we hit a
timeout on statement details, so it doesn't crash
anymore and you can still see the time picker to
be able to select a new time interval.

- Updates the error message, to
clarify it was a timeout error and increase the
timeout from 30s to 30m on the details endpoint.
Fixes #78979

- Updates the last error for statement
details with the proper value, which previously
was using the error for all statements endpoint,
instead of the specific for that fingerprint id.

- Adds a message when page takes longer to load.

- Uses a proper count formatting for
execution count.

Release justification: bug fixes and smaller improvements
Release note (ui change): Proper formatting of execution count
under Statement Details page.
Increase timeout for Statement Details page and shows
proper timeout error when it happens, no longer
crashing the page.

87155: github-post: allow for finding the test in a parent directory of the pkg r=srosenberg,rail a=rickystewart

In some cases the Bazel test runner "incorrectly" reports the package
path for tests. For example, we have [issues](#85376) where the name of
the test is reported as `pkg/.../package/package_test` rather than
`pkg/.../package` as we might expect. I suspect this is confusing
`github-post` when it tries to find tests in the `package_test`
directory rather than the `package` directory.

We address this by allowing `github-post` to search up the directory
tree for the test rather than expecting it to be in one particular
directory.

Also update a repro command to use `dev test` rather than
`make stressrace`.

Closes #85420.

Release justification: Non-production code changes
Release note: None

87156: ci: disable sharding in random syntax tests r=srosenberg a=rickystewart

The different shards were trampling each other's test.json.txt,
preventing failures from being reported accurately.

Release justification: Non-production code changes
Release note: None

87158: sql: clean up node dialer fields r=yuzefovich a=yuzefovich

This commit removes no longer used `nodeDialer` field (for SQL - KV
communication) as well as renames some of the similarly named fields to
`podNodeDialer` to indicate that its only a SQL - SQL dialer.

Release justification: low-risk cleanup.

Release note: None

Co-authored-by: wenyihu3 <[email protected]>
Co-authored-by: Austen McClernon <[email protected]>
Co-authored-by: e-mbrown <[email protected]>
Co-authored-by: Eric Harmeling <[email protected]>
Co-authored-by: Sean Barag <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Marylia Gutierrez <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@healthy-pod healthy-pod added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 17, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-queries SQL Queries Team label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
22.2
4 participants
@ajwerner @yuzefovich @cockroach-teamcity @healthy-pod