Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/sqlstats: record QuerySummary when merging stats #84170

Merged
merged 1 commit into from
Jul 11, 2022
Merged

sql/sqlstats: record QuerySummary when merging stats #84170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkg/sql/logictest/testdata/logic_test/statement_statistics
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,3 +400,19 @@ SELECT * FROM txn_fingerprint_view

statement ok
COMMIT

statement ok
BEGIN; SELECT count(1) AS wombat1; COMMIT

query T
SELECT metadata->>'querySummary' FROM crdb_internal.statement_statistics WHERE metadata->>'query' LIKE '%wombat1%'
----
SELECT count(_) AS wom...

statement ok
SELECT count(1) AS wombat2

query T
SELECT metadata->>'querySummary' FROM crdb_internal.statement_statistics WHERE metadata->>'query' LIKE '%wombat2%'
----
SELECT count(_) AS wom...
1 change: 1 addition & 0 deletions pkg/sql/sqlstats/ssmemstorage/ss_mem_storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,7 @@ func (s *stmtStats) mergeStatsLocked(statistics *roachpb.CollectedStatementStati
s.mu.distSQLUsed = statistics.Key.DistSQL
s.mu.fullScan = statistics.Key.FullScan
s.mu.database = statistics.Key.Database
s.mu.querySummary = statistics.Key.QuerySummary
}

// getStatsForStmt retrieves the per-stmt stat object. Regardless of if a valid
Expand Down