sql/sqlstats: record QuerySummary when merging stats #84170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ericharmeling
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Thanks for digging into this and finding a solution! I also appreciate the detailed explanation. LGTM modulo a linter nit.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
pkg/sql/logictest/testdata/logic_test/statement_statistics line 405 at r1 (raw file):
statement ok BEGIN; SELECT COUNT(1) AS wombat1; COMMIT
linter is complaining about casing
Suggestion:
count(1)
pkg/sql/logictest/testdata/logic_test/statement_statistics line 413 at r1 (raw file):
statement ok SELECT COUNT(1) AS wombat2
same
Suggestion:
count(1)
During execution of a transaction, all statement statistics are collected in an struct local to that transaction, and then flushed to the main ApplicationStats container when the transaction finishes. Previously, when flushing, we failed to copy the QuerySummary field, leading to `metadata->'querySummary'` from being empty in most cases. Prior to ce1b42b this only affected statements in an explicit transaction. After that commit, it affected all statements. Release note (bug fix): Fix a bug that led to the querySummary field in crdb_internal.statements_statistics's metadata column being empty.
stevendanna
force-pushed
the
collect-query-summary
branch
from
141466d to
f880548
Compare
|
TFTR! bors r=ericharmeling |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During execution of a transaction, all statement statistics are
collected in an struct local to that transaction, and then flushed to
the main ApplicationStats container when the transaction finishes.
Previously, when flushing, we failed to copy the QuerySummary field,
leading to
metadata->'querySummary'from being empty in most cases.Prior to ce1b42b this only affected
statements in an explicit transaction. After that commit, it affected
all statements.
Release note (bug fix): Fix a bug that led to the querySummary field
in crdb_internal.statements_statistics's metadata column being empty.