Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload/schemachanger: stabilize schema changer workload #83838

Merged
merged 2 commits into from
Jul 7, 2022
Merged

workload/schemachanger: stabilize schema changer workload #83838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c79f7
workload/schemachange: disable survive/primary region database ops
fqazi Jul 5, 2022
a87a5b6
workload/schemachange: reduce risk of unknown schema errors
fqazi Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/workload/schemachange/error_screening.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ WITH tab_json AS (
GROUP BY name;
`, tableName.String())
if err != nil {
return false, nil, nil, err
return false, nil, nil, og.checkAndAdjustForUnknownSchemaErrors(err)
}

for _, constraint := range constraints {
Expand Down
6 changes: 3 additions & 3 deletions pkg/workload/schemachange/operation_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,16 +246,16 @@ var opWeights = []int{
dropTable: 1,
dropView: 1,
dropSchema: 1,
primaryRegion: 1,
primaryRegion: 0, // Disabled and tracked with #83831
renameColumn: 1,
renameIndex: 1,
renameSequence: 1,
renameTable: 1,
renameView: 1,
setColumnDefault: 1,
setColumnNotNull: 1,
setColumnType: 0, // Disabled and tracked with #66662.
survive: 1,
setColumnType: 0, // Disabled and tracked with #66662.
survive: 0, // Disabled and tracked with #83831
insertRow: 10, // Temporarily reduced because of #80820
validate: 2, // validate twice more often
}
Expand Down