workload/schemachanger: stabilize schema changer workload #83838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the survive/primary region operations inside the schemachange workload would hit would hit "error: attempting to update zone configuration for database schemachange which contains a modified field "voter_constraints". This led to CI failures, while the root cause is somewhere inside our zone config code. To address this we are temporarily disabling these ops stability reasons. Release note: None
Previously, the schemachange workload did not detect unknown schema error due to cockroachdb#6467. This was another spot that is frequently being hit in our CI environment. To address this, this patch will introduce the unknown schema retry logic. Release note: None
|
This change is |
ajwerner
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @fqazi)
|
@ajwerner TFTR! bors r+ |
|
Build succeeded: |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will do the following, to help stabilize the workload under CI: