ui: remove option 10/30 min from SQL Activity page #83229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Reviewed 1 of 16 files at r1, 1 of 6 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kevin-v-ngo)
maryliag
force-pushed
the
remove-tp-options
branch
from
5fb02f5 to
60606a4
Compare
Previously we had the options for 10 and 30min on SQL Activity pages, which created some confusion, since we would always show the last 1h info. This commit remove those 2 options. If the user select any of those options on the Metrics page, it will get updated to 1h on the SQL Activity pages. Fixes cockroachdb#82914 Release note (ui change): Removal of the 10 and 30min options on the SQL Activity page.
maryliag
force-pushed
the
remove-tp-options
branch
from
60606a4 to
e4d7f25
Compare
|
bors r+ |
|
Build succeeded: |
maryliag
added a commit
to maryliag/cockroach
that referenced
this pull request
Jul 8, 2022
The check for valid options with the removal of some options on cockroachdb#83229 didn't took the custom values into consideration. This commit add the option back, allowing the alignment on custom values. Release note (bug fix): Custom time period selection is now aligning between Metrics and SQL Activity page.
craig bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
83619: opt: constrain expression indexes with IS NULL expressions r=mgartner a=mgartner
The optimizer can generate constrained scans over indexes on computed
columns when columns referenced in the computed column expression are
held constant. Consider this example:
CREATE TABLE t (a INT, v INT AS (a + 1) STORED, INDEX v_idx (v))
SELECT * FROM t WHERE a = 1
A constrained scan can be generated over `v_idx` because `v` depends on
`a` and the query filter holds `a` constant.
This commit lifts a restriction that prevented this optimization when
columns referenced in the computed column expression were held constant
to the `NULL` value. As far as I can tell, this restriction is not
necessary. In fact, `@rytaft` had questioned its purpose originally, but
the question was never answered:
#43450 (review)
By lifting this restriction, the optimizer can explore constrained scans
over both indexed computed columns with `IS NULL` expressions and
expression indexes with `IS NULL` expressions.
Fixes #83390
Release note (performance improvement): The optimizer now explores more
efficient query plans when index computed columns and expressions have
`IS NULL` expressions.
84084: bazel: new versions of prebuilt `c-deps` r=srosenberg a=rickystewart
Rebuild these archives to pull in
`52a3a0aa8a707f9bb03802186da0c60b715ed9ce` (change to `jemalloc` to
build without `MADV_FREE`).
Release note: None
84088: ui: fix alignment on custom scale r=maryliag a=maryliag
The check for valid options with the
removal of some options on #83229 didn't took
the custom values into consideration.
This commit add the option back, allowing the alignment
on custom values.
Release note (bug fix): Custom time period selection is now aligning
between Metrics and SQL Activity page.
84155: sql/schemachanger/scbuild: minor cleanup r=ajwerner a=ajwerner
Improves the error handling a tad to make runtime errors and assertion failure.
Fixes a typo.
Release note: None
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Marylia Gutierrez <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
The check for valid options with the removal of some options on #83229 didn't took the custom values into consideration. This commit add the option back, allowing the alignment on custom values. Release note (bug fix): Custom time period selection is now aligning between Metrics and SQL Activity page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: only 2nd commit is relevant to this PR
Previously we had the options for 10 and 30min on
SQL Activity pages, which created some confusion, since
we would always show the last 1h info.
This commit remove those 2 options.
If the user select any of those options on the Metrics
page, it will get updated to 1h on the SQL Activity
pages.
https://www.loom.com/share/226e54322df6456aa2039b5c54f72eb1
Fixes #82914
Release note (ui change): Removal of the 10 and 30min options
on the SQL Activity page.