sql/schemachanger/scbuild: minor cleanup #84155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Improves the error handling a tad to make runtime errors and assertion failure. Fixes a typo. Improves testing output. Release note: None
ajwerner
force-pushed
the
ajwerner/minor-builder-cleanup
branch
from
d3592c3 to
6ea2cce
Compare
ajwerner
commented
Jul 11, 2022
| case nil: | ||
| // No error. | ||
| case runtime.Error: | ||
| err = errors.WithAssertionFailure(recErr) |
There was a problem hiding this comment.
The nice thing about this is that it gives us a stack trace in the case of a nil pointer panic.
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the error handling a tad to make runtime errors and assertion failure.
Fixes a typo.
Release note: None