-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: stats charts on Statement Details page #82960
release-22.1: stats charts on Statement Details page #82960
Conversation
The overview for a statement details page now shows charts instead of just the mean value for: - Execution and Planning Time - Rows Processed - Execution Retries - Execution Count - Contention Fixes cockroachdb#74517 Fixes cockroachdb#81153 This commit also introduces mock for matchMedia and canvas used for testing with jest. Release note (ui change): Statement Details page now shows charts for: Execution and Planning Time, Rows Processed, Execution Retries, Execution Count and Contention.
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
7d2946c
to
29748e3
Compare
This commit adds the proper multiplication factor to contention value. It also fixes two small spacing issues. Release note (bug fix): Use proper multiplying factor to contention value on Statement Details page.
29748e3
to
2bdd346
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 12 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
Backport 1/1 commits from #82426
Backport 1/1 commits from #82911
cc @cockroachdb/release
ui: new charts to statement details page
The overview for a statement details page now
shows charts instead of just the mean value for:
Fixes #74517
Fixes #81153
This commit also introduces mock for matchMedia and canvas
used for testing with jest.
Release note (ui change): Statement Details page now shows charts
for: Execution and Planning Time, Rows Processed, Execution Retries,
Execution Count and Contention.
ui: fix contention chart on Statement Details page
This commit adds the proper multiplication factor to
contention value.
It also fixes two small spacing issues.
Release note (bug fix): Use proper multiplying factor to
contention value on Statement Details page.
Release justification: high benefit change