Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: stats charts on Statement Details page #82960

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

maryliag
Copy link
Contributor

Backport 1/1 commits from #82426
Backport 1/1 commits from #82911

cc @cockroachdb/release


ui: new charts to statement details page
The overview for a statement details page now
shows charts instead of just the mean value for:

  • Execution and Planning Time
  • Rows Processed
  • Execution Retries
  • Execution Count
  • Contention

Fixes #74517
Fixes #81153

This commit also introduces mock for matchMedia and canvas
used for testing with jest.

Release note (ui change): Statement Details page now shows charts
for: Execution and Planning Time, Rows Processed, Execution Retries,
Execution Count and Contention.


ui: fix contention chart on Statement Details page
This commit adds the proper multiplication factor to
contention value.

It also fixes two small spacing issues.

Release note (bug fix): Use proper multiplying factor to
contention value on Statement Details page.


Release justification: high benefit change

The overview for a statement details page now
shows charts instead of just the mean value for:

- Execution and Planning Time
- Rows Processed
- Execution Retries
- Execution Count
- Contention

Fixes cockroachdb#74517
Fixes cockroachdb#81153

This commit also introduces mock for matchMedia and canvas
used for testing with jest.

Release note (ui change): Statement Details page now shows charts
for: Execution and Planning Time, Rows Processed, Execution Retries,
Execution Count and Contention.
@maryliag maryliag requested a review from a team June 15, 2022 21:07
@maryliag maryliag requested a review from a team as a code owner June 15, 2022 21:07
@blathers-crl
Copy link

blathers-crl bot commented Jun 15, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@maryliag maryliag removed the request for review from a team June 15, 2022 21:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag force-pushed the backport22.1-82426-82911 branch 2 times, most recently from 7d2946c to 29748e3 Compare June 16, 2022 15:29
This commit adds the proper multiplication factor to
contention value.

It also fixes two small spacing issues.

Release note (bug fix): Use proper multiplying factor to
contention value on Statement Details page.
@maryliag maryliag force-pushed the backport22.1-82426-82911 branch from 29748e3 to 2bdd346 Compare June 16, 2022 16:24
Copy link
Member

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 12 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)

@maryliag maryliag merged commit 7a265fd into cockroachdb:release-22.1 Jun 21, 2022
@maryliag maryliag deleted the backport22.1-82426-82911 branch June 21, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants