Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix contention chart on Statement Details page #82911

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

maryliag
Copy link
Contributor

This commit adds the proper multiplication factor to
contention value and change title when there are no samples.
Screen Shot 2022-06-14 at 5 18 24 PM

Screen Shot 2022-06-14 at 4 39 08 PM

It also fixes two small spacing issues.
Before
Screen Shot 2022-06-14 at 4 48 28 PM

After
Screen Shot 2022-06-14 at 4 48 18 PM

Release note (bug fix): Use proper multiplying factor to
contention value on Statement Details page.

@maryliag maryliag requested a review from a team June 14, 2022 21:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 15, 2022

Build failed:

This commit adds the proper multiplication factor to
contention value.

It also fixes two small spacing issues.

Release note (bug fix): Use proper multiplying factor to
contention value on Statement Details page.
@maryliag maryliag force-pushed the fix-contention-chart branch from 5b56216 to d77e06d Compare June 16, 2022 14:49
@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 16, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 16, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@craig craig bot merged commit 8f23486 into cockroachdb:master Jun 17, 2022
@craig
Copy link
Contributor

craig bot commented Jun 17, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants