Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: bar chart component and improvements #82887

Conversation

maryliag
Copy link
Contributor

Backport 1/1 commits from #78182.
Backport 1/1 commits from #80197.
Backport 1/1 commits from #80269.
Backport 1/1 commits from #82321.

/cc @cockroachdb/release


ui: remove LineGraphOld
Resolves #76177

This commit removes LineGraphOld component from the codebase.
LineGraphOld component has been replaced by the new LineGraph
component introduced in #63087.

Release note: None


ui: move shared graph components to cluster-ui
Part of #74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None


cluster-ui: create bar graph for time series data
Closes #74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None


ui: fixes on bar chart component
This commit:

  • Updates z-index of legend, so it doesn't get on top of tooltip
  • Fixes the case when there is a single bar (previously not loading)
  • Tooltip shows the value with unit
  • The tooltip fixes to 1 decimal points when the value is a decimal
  • Adds new stories for single bar and chart with scale of Duration
    and Bytes

Release note: None


Release justification: high benefit changes

Azhng and others added 3 commits June 14, 2022 09:27
Resolves cockroachdb#76177

This commit removes LineGraphOld component from the codebase.
LineGraphOld component has been replaced by the new LineGraph
component introduced in cockroachdb#63087.

Release note: None
Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None
Closes cockroachdb#74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None
@maryliag maryliag requested a review from a team June 14, 2022 13:49
@blathers-crl
Copy link

blathers-crl bot commented Jun 14, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag force-pushed the backport22.1-78182-80197-80269-82321 branch 2 times, most recently from 91ae400 to 8e310b0 Compare June 14, 2022 15:52
This commit:
- Updates z-index of legend, so it doesn't get on top of tooltip
- Fixes the case when there is a single bar (previously not loading)
- Tooltip shows the value with unit
- The tooltip fixes to 1 decimal points when the value is a decimal
- Adds new stories for single bar and chart with scale of `Duration`
and `Bytes`

Release note: None
@maryliag maryliag force-pushed the backport22.1-78182-80197-80269-82321 branch from 8e310b0 to cda205c Compare June 14, 2022 16:08
Copy link
Member

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)

@maryliag maryliag merged commit 04c020a into cockroachdb:release-22.1 Jun 15, 2022
@maryliag maryliag deleted the backport22.1-78182-80197-80269-82321 branch June 15, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants