-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: bar chart component and improvements #82887
Merged
maryliag
merged 4 commits into
cockroachdb:release-22.1
from
maryliag:backport22.1-78182-80197-80269-82321
Jun 15, 2022
Merged
release-22.1: bar chart component and improvements #82887
maryliag
merged 4 commits into
cockroachdb:release-22.1
from
maryliag:backport22.1-78182-80197-80269-82321
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves cockroachdb#76177 This commit removes LineGraphOld component from the codebase. LineGraphOld component has been replaced by the new LineGraph component introduced in cockroachdb#63087. Release note: None
Part of cockroachdb#74516 This commit moves shared graph functions and components to cluster-ui package. This is to enable the new bar chart component to share axes utilities and containers with the older line graph component in db-console. Release note: None
Closes cockroachdb#74516 This commit creates a generic bar chart component in the cluster-ui package. The component is intended for use with time series data and should be wrapped in parent components that convert metrics responses from the server to the expected format. Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
maryliag
force-pushed
the
backport22.1-78182-80197-80269-82321
branch
2 times, most recently
from
June 14, 2022 15:52
91ae400
to
8e310b0
Compare
This commit: - Updates z-index of legend, so it doesn't get on top of tooltip - Fixes the case when there is a single bar (previously not loading) - Tooltip shows the value with unit - The tooltip fixes to 1 decimal points when the value is a decimal - Adds new stories for single bar and chart with scale of `Duration` and `Bytes` Release note: None
maryliag
force-pushed
the
backport22.1-78182-80197-80269-82321
branch
from
June 14, 2022 16:08
8e310b0
to
cda205c
Compare
xinhaoz
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #78182.
Backport 1/1 commits from #80197.
Backport 1/1 commits from #80269.
Backport 1/1 commits from #82321.
/cc @cockroachdb/release
ui: remove LineGraphOld
Resolves #76177
This commit removes LineGraphOld component from the codebase.
LineGraphOld component has been replaced by the new LineGraph
component introduced in #63087.
Release note: None
ui: move shared graph components to cluster-ui
Part of #74516
This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.
Release note: None
cluster-ui: create bar graph for time series data
Closes #74516
This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.
Release note: None
ui: fixes on bar chart component
This commit:
Duration
and
Bytes
Release note: None
Release justification: high benefit changes