New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make generic bar chart component #74516

Closed

jocrl opened this issue Jan 6, 2022 · 0 comments · Fixed by #80269

Assignees

Labels

A-sql-console-general C-enhancement

Contributor

jocrl commented Jan 6, 2022 •

edited

Loading

Including the ability to have x-axis tick marks to the left of the bars
Figma mockups: https://www.figma.com/file/xdmwvnFQd6KkO9RJ0XLDH0/22.1_SQL-obsrv_query-performance?node-id=3488%3A10430

David Hartunian made the line graphs with uPlot, and offered to help. He said:

i relied heavily on the source code for various demos https://leeoniya.github.io/uPlot/demos/index.html
and the docs here
https://github.com/leeoniya/uPlot/tree/master/docsplus the Typescript types usually have good info in them as well.
in addition, the developer is quite responsive on github.

CC Jira issue; CRUX asked to keep in touch as this is started: CC-4491

Jira issue: CRDB-12130

Epic CRDB-13581

jocrl added C-enhancement T-sql-observability A-sql-console-general labels

jocrl self-assigned this

jocrl mentioned this issue

Add bar charts to the Statements Details Overview page #74517

Closed

maryliag assigned xinhaoz

exalate-issue-sync bot unassigned jocrl

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          ui: delete unused bar chart component

035f289

Part of cockroachdb#74516

This commit removes the unused `BarChart` component
in db-console.

Release note: None

xinhaoz mentioned this issue

ui: delete unused bar chart component #80194

Merged

xinhaoz mentioned this issue

cluster-ui: add uplot library #80195

Merged

xinhaoz mentioned this issue

ui: move shared graph components to cluster-ui #80197

Merged

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          ui: move shared graph components to cluster-ui

eeacd4b

Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          cluster-ui: add uplot library

cef1248

Part of cockroachdb#74516

This commit adds the uplot library to the cluster-ui package.

Release note: None

craig bot pushed a commit that referenced this issue


          Merge #76881 #80194

55480ac

76881: nightlies: observe TESTS env var r=rail a=tbg

I accidentally[^1] just ran our entire test suite 3x. It's helpful to be
able to narrow it down to specific tests (though arguably roachstress-CI
could be used instead).

[^1]: https://teamcity.cockroachdb.com/viewLog.html?buildId=4424614&buildTypeId=Cockroach_Nightlies_RoachtestNightlyGceBazel&tab=buildResultsDiv&branch_Cockroach_Nightlies=%3Cdefault%3E

Release note: None


80194: ui: delete unused bar chart component r=maryliag a=xinhaoz

Part of #74516

This commit removes the unused `BarChart` component
in db-console.

Release note: None

Co-authored-by: Tobias Grieger <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>

craig bot pushed a commit that referenced this issue


          Merge #80195

e251e61

80195: cluster-ui: add uplot library r=jocrl a=xinhaoz

Part of #74516

This commit adds the uplot library to the cluster-ui package.

Release note: None

Co-authored-by: Xin Hao Zhang <[email protected]>

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          ui: move shared graph components to cluster-ui

46757ab

Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          ui: move shared graph components to cluster-ui

adabb97

Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

xinhaoz mentioned this issue

cluster-ui: create bar graph for time series data #80269

Merged

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          ui: move shared graph components to cluster-ui

b094c6c

Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

craig bot pushed a commit that referenced this issue


          Merge #79967 #79991 #80197 #80335 #80349 #80379

11a0a9f

79967: kv/bulk: parallelize sending SSTs due to range bounds r=dt a=dt

Previously the batcher, when it determined it needed to finish one SST
and send it before starting another, would wait for it to be sent before
moving one. When flushing a buffer that contained data that mapped to
many ranges, this meant many serial flushes, e.g. flushing 512MB of data
from a buffer that had keys uniformly distributed over a table which was
split into 2000 ranges meant waiting for roughly 2000 sequential AddSSTable
requests. When those requests were slow, for example sometimes taking as
much as 1s each or more, this became a major bottleneck.

This change switches the batcher to send files that are ended due to a
round boundary asynchronously, queuing up the request to send and then
starting the next file while it sends, as long as memory capacity in the
monitor allows holding the extra file in memory (as these async sends
could result in using an entire extra buffer's worth of memory if they
all end up in-flight at once, which they easily could if the receivers
are queuing).

Release note (performance improvement): Bulk ingestion of unsorted data during IMPORT and schema changes uses a higher level of parallelism to send produced data to the storage layer.


79991: allocator: carve out a package boundary r=irfansharif a=irfansharif

**allocator/storepool: carve out package from kvserver**

This commit tries to pave the way for the allocator itself to be carved
out (storepool probably being a direct dependency, but ideally through
an interface). This commit shamelessly exports any and everything needed
in order for StorePool to sit outside the kvserver package boundary.
It's unfortunate how tangled up this component is, including in tests
(some of which reach deep into inner mutexes and mutate state). We're
not doing anything to improve the status quo other than moving it and
maybe pointing to the awkwardness.

**allocatorimpl: carve out an allocator package**

Do the same for kvserver/replicastats, a type that's used as an input
for the allocator at various points (needed to break the dependency
between the allocatorimpl and kvserver). We take the same approach as
the last commit, exporting anything and everything needed to introduce a
hard package boundary.


80197: ui: move shared graph components to cluster-ui r=jocrl,maryliag a=xinhaoz

Part of #74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

80335: evalctx: remove some redundant uses of Txn on ExtendedEvalContext  r=otan a=RichardJCai

evalctx: remove some redundant uses of Txn on ExtendedEvalContext

Release note: None

Part of series of effort to get rid of kv.Txn from EvalContext

80349: dev: add example of bench with profiling r=jordanlewis a=jordanlewis

Release note: None

80379: dev: bump version r=dt,erikgrinaker a=rickystewart

Problems with `dev generate cgo` have been [noticed](#79455 (comment))
that are resolved if you re-build.

Release note: None

Co-authored-by: David Taylor <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Jordan Lewis <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          cluster-ui: create bar graph for time series data

233b11a

Closes cockroachdb#74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          cluster-ui: create bar graph for time series data

b3a8789

Closes cockroachdb#74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None

xinhaoz added a commit to xinhaoz/cockroach that referenced this issue


          cluster-ui: create bar graph for time series data

dd58d66

Closes cockroachdb#74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None

craig bot closed this as completed in

3831e27

jlinder added the sync-me-3 label

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          cluster-ui: add uplot library

25a9eb5

Part of cockroachdb#74516

This commit adds the uplot library to the cluster-ui package.

Release note: None

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          ui: move shared graph components to cluster-ui

386914b

Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          cluster-ui: create bar graph for time series data

8cbf561

Closes cockroachdb#74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None

maryliag mentioned this issue

release-22.1: bar chart component and improvements #82729

Closed

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          cluster-ui: add uplot library

1052ba2

Part of cockroachdb#74516

This commit adds the uplot library to the cluster-ui package.

Release note: None

maryliag mentioned this issue

release-22.1: cluster-ui: add uplot library #82745

Merged

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          ui: move shared graph components to cluster-ui

30279ab

Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          cluster-ui: create bar graph for time series data

48954b5

Closes cockroachdb#74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          ui: move shared graph components to cluster-ui

ff738a4

Part of cockroachdb#74516

This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.

Release note: None

maryliag pushed a commit to maryliag/cockroach that referenced this issue


          cluster-ui: create bar graph for time series data

31e3a6b

Closes cockroachdb#74516

This commit creates a generic bar chart component in
the cluster-ui package. The component is intended for
use with time series data and should be wrapped in
parent components that convert metrics responses from
the server to the expected format.

Release note: None

maryliag mentioned this issue

release-22.1: bar chart component and improvements #82887

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment