-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: ccl/sqlproxyccl: enable a more graceful shutdown #82684
Conversation
When a drainSignal is received, the sql proxy now waits for all connections to close within a certain time limit (59 minutes) before shutting down. The next drainSignal will be ignored, but the third will forcefully shut down the server by panicking. This is to resolve an issue with Kubernetes where traffic could be lost during upgrades. See CC-5298 for more details. Release notes: None
ae1c328
to
3190df4
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @blathers-crl[bot])
Backport 1/1 commits from #82317 on behalf of @pjtatlow.
/cc @cockroachdb/release
When a drainSignal is received, the sql proxy now waits for all connections to
close within a certain time limit (59 minutes) before shutting down.
The next drainSignal will be ignored, but the third will forcefully shut down
the server by panicking. This is to resolve an issue with Kubernetes where
traffic could be lost during upgrades. See CC-5298 for more details.
Release notes: None
Release justification: Fixes a bug in the sql proxy that is only used by CC serverless.