ccl/sqlproxyccl: enable a more graceful shutdown #82317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pjtatlow
force-pushed
the
sqlproxy-graceful-shutdown
branch
3 times, most recently
from
f5b24e8 to
22bab19
Compare
pjtatlow
force-pushed
the
sqlproxy-graceful-shutdown
branch
from
22bab19 to
76d7ae1
Compare
pjtatlow
force-pushed
the
sqlproxy-graceful-shutdown
branch
from
76d7ae1 to
b393baa
Compare
When a drainSignal is received, the sql proxy now waits for all connections to close within a certain time limit (59 minutes) before shutting down. The next drainSignal will be ignored, but the third will forcefully shut down the server by panicking. This is to resolve an issue with Kubernetes where traffic could be lost during upgrades. See CC-5298 for more details. Release notes: None
pjtatlow
force-pushed
the
sqlproxy-graceful-shutdown
branch
from
b393baa to
628762b
Compare
pjtatlow
commented
Jun 9, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jeffswenson)
pkg/cli/mt_proxy.go line 168 at r1 (raw file):
Previously, pjtatlow (PJ Tatlow) wrote…
Yeah good idea, I'll do that now!
Done
|
Merging because bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a drainSignal is received, the sql proxy now waits for all connections to
close within a certain time limit (59 minutes) before shutting down.
The next drainSignal will be ignored, but the third will forcefully shut down
the server by panicking. This is to resolve an issue with Kubernetes where
traffic could be lost during upgrades. See CC-5298 for more details.
Release notes: None