Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/catalog/lease: add some event logging around lease acquisition #81857

Conversation

ajwerner
Copy link
Contributor

Before this, there was a black hole of time when we were acquiring a lease.
The singleflight prevents tracing of the actual acquisition.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Before this, there was a black hole of time when we were acquiring a lease.
The singleflight prevents tracing of the actual acquisition.

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/add-some-event-logging-around-lease-acquisition branch from e704de5 to c1b3f2e Compare May 25, 2022 20:28
@ajwerner ajwerner marked this pull request as ready for review May 25, 2022 20:59
@ajwerner ajwerner requested a review from a team May 25, 2022 20:59
Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@ajwerner
Copy link
Contributor Author

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request May 25, 2022
81857: sql/catalog/lease: add some event logging around lease acquisition r=ajwerner a=ajwerner

Before this, there was a black hole of time when we were acquiring a lease.
The singleflight prevents tracing of the actual acquisition.

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
@craig
Copy link
Contributor

craig bot commented May 25, 2022

Build failed:

@ajwerner
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 27, 2022

Build succeeded:

@craig craig bot merged commit 1047fb0 into cockroachdb:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants