Merge #81857

81857: sql/catalog/lease: add some event logging around lease acquisition r=ajwerner a=ajwerner Before this, there was a black hole of time when we were acquiring a lease. The singleflight prevents tracing of the actual acquisition. Release note: None Co-authored-by: Andrew Werner <[email protected]>
cockroachdb · May 25, 2022 · f9afd5a · f9afd5a
2 parents c86696e + c1b3f2e
commit f9afd5a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/sql/catalog/lease/lease.go b/pkg/sql/catalog/lease/lease.go
@@ -470,6 +470,8 @@ func (m *Manager) AcquireFreshestFromStore(ctx context.Context, id descpb.ID) er
 // The boolean returned is true if this call was actually responsible for the
 // lease acquisition.
 func acquireNodeLease(ctx context.Context, m *Manager, id descpb.ID) (bool, error) {
+	start := timeutil.Now()
+	log.VEventf(ctx, 2, "acquiring lease for descriptor %d", id)
 	var toRelease *storedLease
 	resultChan, didAcquire := m.storage.group.DoChan(fmt.Sprintf("acquire%d", id), func() (interface{}, error) {
 		// Note that we use a new `context` here to avoid a situation where a cancellation
@@ -516,6 +518,7 @@ func acquireNodeLease(ctx context.Context, m *Manager, id descpb.ID) (bool, erro
 			return false, result.Err
 		}
 	}
+	log.VEventf(ctx, 2, "acquired lease for descriptor %d, took %v", id, timeutil.Since(start))
 	return didAcquire, nil
 }