Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: execinfrapb: break the dependency on sem/builtins #79077

Merged
merged 1 commit into from
Mar 30, 2022
Merged

release-22.1: execinfrapb: break the dependency on sem/builtins #79077

merged 1 commit into from
Mar 30, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2022 •
edited by yuzefovich
Loading

Backport 1/1 commits from #78470 on behalf of @yuzefovich.

/cc @cockroachdb/release

This commit moves several utility functions from execinfrapb into
execinfra package in order to break the dependency of the former on
sem/builtins (which eventually depends on the c-deps).

Fixes: #78453.

Release note: None

Release justification: low risk code movement to clean up the dependencies.

@yuzefovich
execinfrapb: break the dependency on sem/builtins
d969a06 
This commit moves several utility functions from `execinfrapb` into
`execinfra` package in order to break the dependency of the former on
`sem/builtins` (which eventually depends on the `c-deps`).

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-78470 branch from 2271fd5 to d969a06 Compare March 30, 2022 18:54
@blathers-crl blathers-crl bot requested review from Azhng and mgartner March 30, 2022 18:54
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 30, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

mgartner
mgartner approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @Azhng)

@yuzefovich yuzefovich merged commit 595ee25 into release-22.1 Mar 30, 2022
@yuzefovich yuzefovich deleted the blathers/backport-release-22.1-78470 branch March 30, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@Azhng Azhng Awaiting requested review from Azhng

Assignees

@yuzefovich yuzefovich

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @mgartner @yuzefovich