execinfrapb: break the dependency on sem/builtins #78470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves several utility functions from `execinfrapb` into `execinfra` package in order to break the dependency of the former on `sem/builtins` (which eventually depends on the `c-deps`). Release note: None
|
This change is |
mgartner
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Azhng)
|
TFTR! bors r+ |
|
Build succeeded: |
|
@Azhng do you want this to be backported to 22.1? |
|
Hmm good question, cc @ajwerner what's your thoughts on this? |
|
I don't feel strongly. I think the reason to do it is to make future backports less likely to hit conflicts. I vote we may as well do it. It seems to me to carry near zero risk. |
|
Yeah, sounds good to me. |
|
blathers backport 22.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves several utility functions from
execinfrapbintoexecinfrapackage in order to break the dependency of the former onsem/builtins(which eventually depends on thec-deps).Fixes: #78453.
Release note: None