Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql/row: limit row converter batches to 4MB #78957

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 29, 2022

Backport 1/1 commits from #78945 on behalf of @dt.

/cc @cockroachdb/release


These small batches are used to reduce channel overhead when passing KVs
to the IMPORT ingest process, where we actually has move sophisticated
memory monitoring in place around the big buffers. They are expected to
be small and ephemeral, but for tables with very large rows, 5k KVs can
actually become a non-trivial amount of used memory. This adds a second limit
that triggers a flush if >4MB of key/value slice cap has been added to the
batch.

Release note: none.


Release justification: bug fix.

These small batches are used to reduce channel overhead when passing KVs
to the IMPORT ingest process, where we actually has move sophisticated
memory monitoring in place around the big buffers. They are expected to
be small and ephemeral, but for tables with very large rows, 5k KVs can
actually become a non-trivial amount of used memory. This adds a second limit
that triggers a flush if >4MB of key/value slice cap has been added to the
batch.

Release note: none.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-78945 branch from 5a64b6b to 2ccc5e3 Compare March 29, 2022 15:02
@blathers-crl blathers-crl bot requested review from adityamaru and msbutler March 29, 2022 15:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 29, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 29, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt merged commit d632696 into release-22.1 Apr 13, 2022
@dt dt deleted the blathers/backport-release-22.1-78945 branch April 13, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants