sql/row: limit row converter batches to 4MB #78945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These small batches are used to reduce channel overhead when passing KVs to the IMPORT ingest process, where we actually has move sophisticated memory monitoring in place around the big buffers. They are expected to be small and ephemeral, but for tables with very large rows, 5k KVs can actually become a non-trivial amount of used memory. This adds a second limit that triggers a flush if >4MB of key/value slice cap has been added to the batch. Release note: none.
|
This change is |
adityamaru
approved these changes
Mar 29, 2022
|
TFTR! bors r+ |
|
Build succeeded: |
This was referenced Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These small batches are used to reduce channel overhead when passing KVs
to the IMPORT ingest process, where we actually has move sophisticated
memory monitoring in place around the big buffers. They are expected to
be small and ephemeral, but for tables with very large rows, 5k KVs can
actually become a non-trivial amount of used memory. This adds a second limit
that triggers a flush if >4MB of key/value slice cap has been added to the
batch.
Release note: none.