-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: workload/schemachanger: primary index detection is incorrect #78329
Conversation
Fixes: #77885 Previously, the schemachanger workload incorrectly detected primary indexes using their names checking for either the words 'pkey' or 'primary'. This approach was not correct and heuristic in nature. To address this, this patch uses crdb_internal.table_indexes to detect primary indexes. Release note: None
4cd46fb
to
77ff7d4
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @postamar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @postamar)
Backport 1/1 commits from #78184 on behalf of @fqazi.
/cc @cockroachdb/release
Fixes: #77885, #78304
Previously, the schemachanger workload incorrectly detected primary
indexes using their names checking for either the words
'pkey' or 'primary'. This approach was not correct and heuristic
in nature. To address this, this patch uses crdb_internal.table_indexes
to detect primary indexes.
Release note: None
Release justification: low risk only fixes a test case bug.