Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: schemachange/mixed-versions failed #77885

Closed
cockroach-teamcity opened this issue Mar 16, 2022 · 5 comments · Fixed by #78184
Closed

roachtest: schemachange/mixed-versions failed #77885

cockroach-teamcity opened this issue Mar 16, 2022 · 5 comments · Fixed by #78184
Assignees
@fqazi
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 16, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.schemachange/mixed-versions failed with artifacts on release-22.1 @ a1c1879e01ceee79a81693c67a1dba184b5fc1b1:

		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE SCHEMA IF NOT EXISTS schema35 AUTHORIZATION root",
		  |   "ALTER DATABASE schemachange SURVIVE REGION FAILURE"
		  |  ],
		  |  "expectedExecErrors": "22023,42602",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 22023,42602===========================Executed queries for generating errors: QUERY [SELECT region FROM [SHOW REGIONS FROM DATABASE]] : \nQUERY [SHOW DATABASE] :schemachange\n===========================Previous statements [CREATE SCHEMA IF NOT EXISTS schema35 AUTHORIZATION root ALTER DATABASE schemachange SURVIVE REGION FAILURE]: ERROR: database must have associated regions before a survival goal can be set (SQLSTATE 42602)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:21.166557",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE TYPE schema48.enum49 AS ENUM ('fsaaf', 'das', 'afa')"
		  |  ],
		  |  "expectedExecErrors": "3F000",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 3F000===========================Executed queries for generating errors: QUERY [\"SELECT EXISTS (\\n\\tSELECT schema_name\\n\\t\\tFROM information_schema.schemata\\n   WHERE schema_name = $1\\n\\t)\" [\"schema48\"]] :false\n===========================Previous statements [CREATE TYPE schema48.enum49 AS ENUM ('fsaaf', 'das', 'afa')]: ERROR: cannot create \"schema48.enum49\" because the target database or schema does not exist (SQLSTATE 3F000)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:21.30131",
		  |  "ops": [
		  |   "BEGIN",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:21.144218",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER DATABASE schemachange ADD REGION \"us-east1\""
		  |  ],
		  |  "expectedExecErrors": "42P12",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42P12===========================Executed queries for generating errors: QUERY [SELECT region FROM [SHOW REGIONS FROM CLUSTER]] : us-east1,\nQUERY [SELECT region FROM [SHOW REGIONS FROM DATABASE]] : \nQUERY [SHOW DATABASE] :schemachange\n===========================Previous statements [ALTER DATABASE schemachange ADD REGION \"us-east1\"]: ERROR: cannot add region \"us-east1\" to database schemachange (SQLSTATE 42P12)"
		  | }
		Wraps: (4) SSH_PROBLEM
		Wraps: (5) Node 1. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=true --max-ops 100 --concurrency 5 {pgurl:1-4}
		  | ``````
		Wraps: (6) exit status 255
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.SSH (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

Jira issue: CRDB-13810
@cockroach-teamcity cockroach-teamcity added branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 16, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Mar 16, 2022
@cockroach-teamcity cockroach-teamcity mentioned this issue Mar 16, 2022
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.schemachange/mixed-versions failed with artifacts on release-22.1 @ 2d49a7bd0d1ebeff93277233695411d25b2a5d39:

		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "TXN RETRY ERROR; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh): \"sql txn\" meta={id=74e964b6 key=/Table/SystemConfigSpan/Start pri=0.00269883 epo=0 ts=1647494719.099136935,2 min=1647494719.063647771,0 seq=17} lock=true stat=PENDING rts=1647494719.063647771,0 wto=false gul=1647494719.563647771,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:19.063821",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER DATABASE schemachange PRIMARY REGION \"us-east1\"",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "TXN RETRY ERROR; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh): \"sql txn\" meta={id=af154956 key=/Table/SystemConfigSpan/Start pri=0.01128390 epo=0 ts=1647494719.114431813,1 min=1647494719.063738817,0 seq=24} lock=true stat=PENDING rts=1647494719.063738817,0 wto=false gul=1647494719.563738817,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:19.155746",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER DATABASE schemachange SURVIVE ZONE FAILURE"
		  |  ],
		  |  "expectedExecErrors": "42602",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42602===========================Executed queries for generating errors: QUERY [SELECT region FROM [SHOW REGIONS FROM DATABASE]] : \nQUERY [SHOW DATABASE] :schemachange\n===========================Previous statements [ALTER DATABASE schemachange SURVIVE ZONE FAILURE]: ERROR: database must have associated regions before a survival goal can be set (SQLSTATE 42602)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:19.06399",
		  |  "ops": [
		  |   "BEGIN",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "DROP VIEW IF EXISTS public.view22",
		  |   "CREATE SCHEMA schema25 AUTHORIZATION root",
		  |   "ALTER DATABASE schemachange ADD REGION \"us-east1\""
		  |  ],
		  |  "expectedExecErrors": "42P12",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42P12===========================Executed queries for generating errors: QUERY [SELECT region FROM [SHOW REGIONS FROM CLUSTER]] : us-east1,\nQUERY [SELECT region FROM [SHOW REGIONS FROM DATABASE]] : \nQUERY [SHOW DATABASE] :schemachange\n===========================Previous statements [SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs() DROP VIEW IF EXISTS public.view22 CREATE SCHEMA schema25 AUTHORIZATION root ALTER DATABASE schemachange ADD REGION \"us-east1\"]: ERROR: cannot add region \"us-east1\" to database schemachange (SQLSTATE 42P12)"
		  | }
		Wraps: (4) SSH_PROBLEM
		Wraps: (5) Node 4. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=true --max-ops 100 --concurrency 5 {pgurl:1-4}
		  | ``````
		Wraps: (6) exit status 255
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.SSH (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.schemachange/mixed-versions failed with artifacts on release-22.1 @ d7252106b166f23d791a4d677afdbc46b6b059ae:

		  |   "DROP SCHEMA \"schema92\" CASCADE",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:27:52.642083",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE SCHEMA IF NOT EXISTS schema176 AUTHORIZATION root",
		  |   "DROP SCHEMA \"schema113\" CASCADE",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "TXN RETRY ERROR; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh): \"sql txn\" meta={id=4757a253 key=/Table/SystemConfigSpan/Start pri=0.03948766 epo=0 ts=1647581272.660417738,1 min=1647581272.641952595,0 seq=37} lock=true stat=PENDING rts=1647581272.641952595,0 wto=false gul=1647581273.141952595,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:27:52.593607",
		  |  "ops": [
		  |   "BEGIN",
		  |   "DROP SEQUENCE public.seq115",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:27:52.725297",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE TYPE public.enum68 AS ENUM ('asad', 'sadfa', 'df', 'saaf')"
		  |  ],
		  |  "expectedExecErrors": "42710",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42710===========================Executed queries for generating errors: QUERY [\"SELECT EXISTS (\\n\\tSELECT schema_name\\n\\t\\tFROM information_schema.schemata\\n   WHERE schema_name = $1\\n\\t)\" [\"public\"]] :true\n===========================Previous statements [CREATE TYPE public.enum68 AS ENUM ('asad', 'sadfa', 'df', 'saaf')]: ERROR: type \"schemachange.public.enum68\" already exists (SQLSTATE 42710)"
		  | }
		Wraps: (4) SSH_PROBLEM
		Wraps: (5) Node 1. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=true --max-ops 100 --concurrency 5 {pgurl:1-4}
		  | ``````
		Wraps: (6) exit status 255
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.SSH (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.schemachange/mixed-versions failed with artifacts on release-22.1 @ f5b42a4e3bbdadb25aee89a41871239a624d538d:

		  |  "expectedExecErrors": "42P01",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42P01===========================Executed queries for generating errors: QUERY [\"SELECT EXISTS (\\n\\tSELECT sequence_name\\n    FROM information_schema.sequences\\n   WHERE sequence_schema = $1\\n     AND sequence_name = $2\\n   )\" [\"public\" \"seq116\"]] :false\n===========================Previous statements [SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs() DROP SEQUENCE public.seq116]: ERROR: relation \"public.seq116\" does not exist (SQLSTATE 42P01)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:30:12.496213",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE SCHEMA IF NOT EXISTS schema113 AUTHORIZATION root",
		  |   "ALTER SEQUENCE public.seq77 RENAME TO schema113.seq115"
		  |  ],
		  |  "expectedExecErrors": "42602",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42602===========================Executed queries for generating errors: QUERY [\"SELECT EXISTS (\\n\\tSELECT sequence_name\\n    FROM information_schema.sequences\\n   WHERE sequence_schema = $1\\n     AND sequence_name = $2\\n   )\" [\"public\" \"seq77\"]] :true\nQUERY [\"SELECT EXISTS (\\n\\tSELECT schema_name\\n\\t\\tFROM information_schema.schemata\\n   WHERE schema_name = $1\\n\\t)\" [\"schema113\"]] :true\nQUERY [\"SELECT EXISTS (\\n\\tSELECT sequence_name\\n    FROM information_schema.sequences\\n   WHERE sequence_schema = $1\\n     AND sequence_name = $2\\n   )\" [\"schema113\" \"seq115\"]] :false\n===========================Previous statements [CREATE SCHEMA IF NOT EXISTS schema113 AUTHORIZATION root ALTER SEQUENCE public.seq77 RENAME TO schema113.seq115]: ERROR: cannot change schema of table with RENAME (SQLSTATE 42602)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:30:12.676844",
		  |  "ops": [
		  |   "BEGIN",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:30:12.251439",
		  |  "ops": [
		  |   "BEGIN",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "CREATE SCHEMA schema86 AUTHORIZATION root",
		  |   "CREATE SEQUENCE IF NOT EXISTS public.seq107",
		  |   "ALTER SEQUENCE public.seq46 RENAME TO public.seq109",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		Wraps: (4) SSH_PROBLEM
		Wraps: (5) Node 3. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=true --max-ops 100 --concurrency 5 {pgurl:1-4}
		  | ``````
		Wraps: (6) exit status 255
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.SSH (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.schemachange/mixed-versions failed with artifacts on release-22.1 @ a25a145510d5d0bc7570db327a21cd3fcde21980:

		  |   "CREATE TYPE public.enum18 AS ENUM ('adssf')",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "TXN RETRY ERROR; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh): \"sql txn\" meta={id=4876a832 key=/Table/SystemConfigSpan/Start pri=0.00179657 epo=0 ts=1647753941.681602497,1 min=1647753941.681403295,0 seq=9} lock=true stat=PENDING rts=1647753941.681403295,0 wto=false gul=1647753942.181403295,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:41.681761",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE TYPE public.enum15 AS ENUM ('sa', 'f', 'daddaa')",
		  |   "CREATE TABLE IF NOT EXISTS public.table19 (col19_20 GEOGRAPHY, col19_21 TIMESTAMP, col19_22 DATE, col19_23 DATE, col19_24 TIMESTAMP NULL, col19_25 \"char\", col19_26 INTERVAL[] NOT NULL, col19_27 GEOMETRY NULL, col19_28 INET NULL, col19_29 REGNAMESPACE NOT NULL, col19_30 BYTES NOT NULL, col19_31 TIMESTAMPTZ, col19_32 STRING AS (CASE WHEN col19_31 IS NULL THEN e'PUkLC\\x12\\x14':::STRING ELSE e'\\bd\\x1b\\t\\x11-``|':::STRING END) STORED, FAMILY (col19_24, col19_29), FAMILY (col19_22), FAMILY (col19_32, col19_25), FAMILY (col19_30), FAMILY (col19_27), FAMILY (col19_23, col19_28), FAMILY (col19_21), FAMILY (col19_31, col19_26, col19_20))",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:41.662602",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE SCHEMA IF NOT EXISTS public AUTHORIZATION root",
		  |   "ALTER DATABASE schemachange SURVIVE REGION FAILURE"
		  |  ],
		  |  "expectedExecErrors": "22023,42602",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 22023,42602===========================Executed queries for generating errors: QUERY [SELECT region FROM [SHOW REGIONS FROM DATABASE]] : \nQUERY [SHOW DATABASE] :schemachange\n===========================Previous statements [CREATE SCHEMA IF NOT EXISTS public AUTHORIZATION root ALTER DATABASE schemachange SURVIVE REGION FAILURE]: ERROR: database must have associated regions before a survival goal can be set (SQLSTATE 42602)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:25:41.805329",
		  |  "ops": [
		  |   "BEGIN",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "ERROR: restart transaction: TransactionRetryWithProtoRefreshError: ReadWithinUncertaintyIntervalError: read at time 1647753941.805278229,0 encountered previous write with future timestamp 1647753941.805278229,1 within uncertainty interval ``t \u003c= (local=1647753941.807751600,0, global=1647753942.305278229,0)``; observed timestamps: [{2 1647753941.807751600,0} {3 1647753941.806851606,0} {4 1647753941.805278229,0}]: \"sql txn\" meta={id=14308bfa pri=0.01724442 epo=0 ts=1647753941.805278229,0 min=1647753941.805278229,0 seq=0} lock=false stat=PENDING rts=1647753941.805278229,0 wto=false gul=1647753942.305278229,0 (SQLSTATE 40001)"
		  | }
		Wraps: (4) SSH_PROBLEM
		Wraps: (5) Node 2. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=true --max-ops 100 --concurrency 5 {pgurl:1-4}
		  | ``````
		Wraps: (6) exit status 255
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.SSH (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

fqazi added a commit to fqazi/cockroach that referenced this issue Mar 21, 2022
@fqazi
workload/schemachanger: primary index detection is incorrect
79e131c 
Fixes: cockroachdb#77885

Previously, the schemachanger workload incorrectly detected primary
indexes using their names checking for either the words
'pkey' or 'primary'. This approach was not correct and heuristic
in nature. To address this, this patch uses crdb_internal.table_indexes
to detect primary indexes.

Release note: None
@fqazi fqazi mentioned this issue Mar 21, 2022
Merged
@cockroach-teamcity
Copy link
Member Author

roachtest.schemachange/mixed-versions failed with artifacts on release-22.1 @ ec0a78bbf61f7d71fe4222cc1c11d262936df2e3:

		  |   "ALTER DATABASE schemachange PRIMARY REGION \"us-east1\""
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_WRITE_TOO_OLD - WriteTooOld flag converted to WriteTooOldError): \"sql txn\" meta={id=ddd640d7 key=/Table/SystemConfigSpan/Start pri=0.01498042 epo=0 ts=1647926802.610713574,1 min=1647926802.550527448,0 seq=1} lock=true stat=PENDING rts=1647926802.550527448,0 wto=false gul=1647926803.050527448,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:26:42.383282",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE TYPE schema18.enum71 AS ENUM ('dsff', 'a', 'fdd')",
		  |   "ALTER SEQUENCE public.seq22 RENAME TO public.seq77",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:26:42.617525",
		  |  "ops": [
		  |   "BEGIN",
		  |   "DROP SEQUENCE IF EXISTS schema18.seq97",
		  |   "ALTER TABLE schema18.table99 ALTER COLUMN IrrelevantColumnName SET DEFAULT \"IrrelevantValue\""
		  |  ],
		  |  "expectedExecErrors": "42P01",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42P01===========================Executed queries for generating errors: QUERY [\"SELECT EXISTS (\\n\\tSELECT table_name\\n    FROM information_schema.tables \\n   WHERE table_schema = $1\\n     AND table_name = $2\\n   )\" [\"schema18\" \"table99\"]] :false\n===========================Previous statements [DROP SEQUENCE IF EXISTS schema18.seq97 ALTER TABLE schema18.table99 ALTER COLUMN IrrelevantColumnName SET DEFAULT \"IrrelevantValue\"]: ERROR: relation \"schema18.table99\" does not exist (SQLSTATE 42P01)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "05:26:42.600667",
		  |  "ops": [
		  |   "BEGIN",
		  |   "DROP SCHEMA \"schema18\" CASCADE",
		  |   "ALTER DATABASE schemachange ADD REGION \"us-east1\""
		  |  ],
		  |  "expectedExecErrors": "42P12",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error. Dumping state before death:\nExpected errors: 42P12===========================Executed queries for generating errors: QUERY [SELECT region FROM [SHOW REGIONS FROM CLUSTER]] : us-east1,\nQUERY [SELECT region FROM [SHOW REGIONS FROM DATABASE]] : \nQUERY [SHOW DATABASE] :schemachange\n===========================Previous statements [DROP SCHEMA \"schema18\" CASCADE ALTER DATABASE schemachange ADD REGION \"us-east1\"]: ERROR: cannot add region \"us-east1\" to database schemachange (SQLSTATE 42P12)"
		  | }
		Wraps: (4) SSH_PROBLEM
		Wraps: (5) Node 4. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=true --max-ops 100 --concurrency 5 {pgurl:1-4}
		  | ``````
		Wraps: (6) exit status 255
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.SSH (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Mar 22, 2022
@fqazi @yuzefovich
Merge #78184 #78195
420c418 
78184: workload/schemachanger: primary index detection is incorrect r=fqazi a=fqazi

Fixes: #77885

Previously, the schemachanger workload incorrectly detected primary
indexes using their names checking for either the words
'pkey' or 'primary'. This approach was not correct and heuristic
in nature. To address this, this patch uses crdb_internal.table_indexes
to detect primary indexes.

Release note: None

78195: distsql: clean up the determination of txn type in mixed version r=yuzefovich a=yuzefovich

This commit cleans up the way we determine what txn type to use for
a particular flow.

Addresses: #78150.

Release note: None

Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
@craig craig bot closed this as completed in 5b3be20 Mar 22, 2022
@craig craig bot closed this as completed in #78184 Mar 22, 2022
@blathers-crl blathers-crl bot mentioned this issue Mar 23, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Mar 23, 2022
@fqazi
workload/schemachanger: primary index detection is incorrect
77ff7d4 
Fixes: #77885

Previously, the schemachanger workload incorrectly detected primary
indexes using their names checking for either the words
'pkey' or 'primary'. This approach was not correct and heuristic
in nature. To address this, this patch uses crdb_internal.table_indexes
to detect primary indexes.

Release note: None
@healthy-pod healthy-pod added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workload/schemachanger: primary index detection is incorrect fqazi/cockroach
3 participants
@fqazi @cockroach-teamcity @healthy-pod