ui: set index created time as last used time #78283
Conversation
|
This change is |
THardy98
force-pushed
the
create_time_default_index
branch
2 times, most recently
from
7367ee5 to
144eef0
Compare
There was a problem hiding this comment.
Nice! 
Reviewed 1 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @matthewtodd and @THardy98)
pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx, line 247 at r1 (raw file):
return "Never"; } switch (indexStat.lastUsedType) {
Is it okay to get rid of this switch statement now, and just always return formatDate(...)?
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx, line 247 at r1 (raw file):
Previously, matthewtodd (Matthew Todd) wrote…
Is it okay to get rid of this switch statement now, and just always return
formatDate(...)?
Definitely, I wasn't certain if listing the cases would make it clearer what's happening here or not, but I suppose it's unnecessary.
THardy98
force-pushed
the
create_time_default_index
branch
from
144eef0 to
5988855
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx, line 247 at r1 (raw file):
Previously, THardy98 (Thomas Hardy) wrote…
Definitely, I wasn't certain if listing the cases would make it clearer what's happening here or not, but I suppose it's unnecessary.
Removed the switch statement.
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/databases/databaseTablePage/redux.spec.ts, line 146 at r2 (raw file):
} describe.only("Database Table Page", function() {
nit: remove the only before merging
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/databases/databaseTablePage/redux.spec.ts, line 146 at r2 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
nit: remove the only before merging
Good catch!
Previously, database table page on db-console displayed "Never" when there was no Last Read or Last Reset timestamp. This change sets the default message to display the creation time of the timestamp if it exists. Release note (ui change): add index created time as an option on the db-console database table page
THardy98
force-pushed
the
create_time_default_index
branch
from
5988855 to
761837d
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/databases/databaseTablePage/redux.spec.ts, line 146 at r2 (raw file):
Previously, matthewtodd (Matthew Todd) wrote…
Good catch!
^ that goes double :)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
|
bors r+ |
1 similar comment
|
bors r+ |
|
Build succeeded: |
Resolves: #73766
Previously, database table page on db-console displayed "Never" when
there was no Last Read or Last Reset timestamp. This change sets the
default message to display the creation time of the timestamp if it
exists.
Release note (ui change): add index created time as an option on the
database table page