Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Create time as the default Last Used time for Index Stats table #73766

Closed
lindseyjin opened this issue Dec 13, 2021 · 0 comments · Fixed by #78283
Closed

Add Create time as the default Last Used time for Index Stats table #73766

lindseyjin opened this issue Dec 13, 2021 · 0 comments · Fixed by #78283
Assignees
@THardy98
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@lindseyjin
Copy link
Contributor

lindseyjin commented Dec 13, 2021 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.
Blocked by #72626

Currently, the Last Used column on the Index Stats table shows either Last Read or Last Reset, depending on whatever was more recent. If there is no Last Read or Last Reset timestamp, it simply displays "Never".

Describe the solution you'd like

Once index create time is added as a column to the crdb_internal.index_usage_statistics table, we want to show "Created" as the default value for the Last Used column, for when there is no Last Read or Last Reset time.

Additional context

Refer to Figma mocks for more context: https://www.figma.com/file/xdmwvnFQd6KkO9RJ0XLDH0/22.1_SQL-obsrv_query-performance?node-id=3498%3A33376

Code pointer:

cockroach/pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx

Line 217 in 406e0fe

// TODO(lindseyjin): replace default case with create time after it's added to table_indexes

Epic CRDB-9075

Jira issue: CRDB-11735
@lindseyjin lindseyjin added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Dec 13, 2021
@THardy98 THardy98 mentioned this issue Mar 22, 2022
Merged
@craig craig bot closed this as completed in 9ce61ef Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@THardy98 THardy98

Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: set index created time as last used time THardy98/cockroach
2 participants
@THardy98 @lindseyjin