sql: new built-in function crdb_internal.active_version()
#77233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
approved these changes
Mar 1, 2022
| ReturnType: tree.FixedReturnType(types.Jsonb), | ||
| Fn: func(ctx *tree.EvalContext, _ tree.Datums) (tree.Datum, error) { | ||
| activeVersion := ctx.Settings.Version.ActiveVersionOrEmpty(ctx.Context) | ||
| jsonStr, err := gojson.Marshal(&activeVersion.Version) |
There was a problem hiding this comment.
does this behave correctly if "empty" was returned by ActiveVersionOrEmpty? (asking mostly to be educated, since i don't quite know when the version would be empty.)
There was a problem hiding this comment.
it's empty if for some reason this function is called before the cluster is done initializing. In the SQL layer, that's about impossible since we don't let SQL start before cluster init.
knz
force-pushed
the
20220301-active-version
branch
from
a71e07d to
d434470
Compare
|
TFYR! bors r=rafiss |
Release justification: low risk, high benefit changes to existing functionality Release note (sql change): The new built-in scalar function `crdb_internal.active_version()` can now be used alongside `crdb_internal.is_at_least_version()` to determine which cluster version is currently active and choose client-side feature levels accordingly.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): The new built-in scalar function
crdb_internal.active_version()can now be used alongsidecrdb_internal.is_at_least_version()to determine which clusterversion is currently active and choose client-side feature levels
accordingly.