Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: dev generate does not generate the swagger files #77395

Closed
knz opened this issue Mar 5, 2022 · 2 comments · Fixed by #79242
Closed

bazel: dev generate does not generate the swagger files #77395

knz opened this issue Mar 5, 2022 · 2 comments · Fixed by #79242
Assignees
@rickystewart
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@knz
Copy link
Contributor

knz commented Mar 5, 2022 •
edited by exalate-issue-sync bot
Loading

Describe the problem

Found in #77233 / https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests_CheckGeneratedCode/4484914?showRootCauses=false&expandBuildChangesSection=true&expandBuildDeploymentsSection=true&expandBuildProblemsSection=true

dev generate runs to completion but fails to re-generate docs/generated/swagger/spec.json.

Jira issue: CRDB-13570

Epic CRDB-8036
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system T-dev-inf labels Mar 5, 2022
@rickystewart
Copy link
Collaborator

When I discussed this with docs folks last year the opinion was the docs/generated/swagger stuff was stale and not used for anything. Let me follow up on this.

@knz
Copy link
Contributor Author

knz commented Mar 7, 2022

I don't mind that, but then we need to change CI rules so that PRs don't get blocked because the file is stale.

@rickystewart rickystewart mentioned this issue Apr 1, 2022
Merged
craig bot pushed a commit that referenced this issue Apr 1, 2022
@adityamaru @rickystewart
Merge #78430 #79167 #79236 #79242
675eb23 
78430: backupccl: datadrivenify the restore OnFailOrCancel tests r=msbutler a=adityamaru

This change ports all the "cleanup on failed or canceled restore"
tests to the datadriven framework. To make this possible new instructions
have been added to the datadriven framework, please refer to the header
comment for details about each one.

Informs: #77129

Release note: None

79167: bazel: update arguments passed to `configure` for dev macOS arm builds r=mari-crl a=rickystewart

Release note: None

79236: dev: `lint` should honor the number of CPUs when building cockroach r=irfansharif a=rickystewart

Release note: None

79242: docs: generate swagger docs w/ bazel r=mari-crl,rail a=rickystewart

Also build in CI as well as `dev generate docs`.

Closes #77395.

Release note: None

Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in d52f609 Apr 1, 2022
blathers-crl bot pushed a commit that referenced this issue Apr 1, 2022
@rickystewart
docs: generate swagger docs w/ bazel
db58cf6 
Also build in CI as well as `dev generate docs`.

Closes #77395.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Apr 1, 2022
Closed
rickystewart added a commit to rickystewart/cockroach that referenced this issue Apr 4, 2022
@rickystewart
docs: generate swagger docs w/ bazel
9fe6caa 
Also build in CI as well as `dev generate docs`.

Closes cockroachdb#77395.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickystewart rickystewart

Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: generate swagger docs w/ bazel rickystewart/cockroach
2 participants
@knz @rickystewart