Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tenantsettings: delete overrides when removing tenant #76716

Merged
merged 1 commit into from
Feb 18, 2022
Merged

tenantsettings: delete overrides when removing tenant #76716

merged 1 commit into from
Feb 18, 2022

Conversation

RaduBerinde
Copy link
Member

Release note: None

@RaduBerinde RaduBerinde requested a review from ajwerner February 16, 2022 23:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde force-pushed the tenant-settings-cleanup branch from 52f6640 to e81c2e7 Compare February 17, 2022 16:49
@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 17, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@RaduBerinde RaduBerinde mentioned this pull request Feb 17, 2022
Closed
16 tasks
@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 17, 2022

Already running a review

@craig
Copy link
Contributor

craig bot commented Feb 17, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 18, 2022

Build succeeded:

@craig craig bot merged commit 44d2361 into cockroachdb:master Feb 18, 2022
@RaduBerinde RaduBerinde deleted the tenant-settings-cleanup branch February 18, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaduBerinde @cockroach-teamcity @stevendanna