-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
72586: bazel, docker: run docker image tests, and increase memory allocation to docker image in CI r=ZhouXing19 a=ZhouXing19 This PR is to add a test infrastructure for docker image in TeamCity using bazel, and also increase the allocated memory to the `cockroach-ci` docker image in the CI. It downloads the docker image tar from an upstream build configuration (Build Docker Image), loads the docker image from the tar, builds a docker container based on it, and runs SQL queries inside that container. Release note: None 76243: server: Fix regression on /jobs/:id page. r=benbardin a=benbardin Job details page is currently broken on master. Looks like the bug was introduced in 931957c. I added a test to protect against this going forward! Release note: None 76540: ci,dev: allow injecting cockroach binary into `compose` tests r=rail a=rickystewart Same sort of thing we do in `acceptance`: build the `cockroach` and `compare_test` binaries ahead of time and pass the locations to the binaries as flags. Release note: None 76605: changefeedccl: periodic pts record updates r=samiskin a=samiskin Previously changefeeds only laid down protected timestamp records to protect against either an ongoing backfill or the changefeed lagging behind. This is insufficient in cases such as if the gcttl is very short, recurring errors retry the changefeed for too long, or in upcoming work to enable serverless to shut down idle changefeeds. This PR removes the manual PTS protection on backfills and begins an async routine on the changeFrontier that updates the protected timestamp record to the current highwater mark. Fixes #76247 Release note (enterprise change): changefeeds running on tables with a low gcttl will function more reliably due to protected timestamps being maintained for the changefeed targets at the resolved timestamp of the changefeed. The frequency at which the protected timestamp is updated to the resolved timestamp can be configured through the `changefeed.protect_timestamp_interval` cluster setting. If the changefeed lags too far behind such that storage of old data becomes an issue, cancelling the changefeed will release the protected timestamps and allow garbage collection to resume. If `protect_data_from_gc_on_pause` is unset, pausing the changefeed will release the existing protected timestamp record. 76641: sql: only create a LeafTxn for local flows if Streamer is enabled r=yuzefovich a=yuzefovich Previously, during the flow setup stage we would always choose to create a LeafTxn for local flows if there is a processor that might use a Streamer API. This was the case even when the Streamer is disabled by a cluster setting. Such behavior is a regression (since leaf txns don't have a transparent span refresh mechanism and read spans have to be collected with the metadata at the end of the execution), so this commit fixes things by only using a LeafTxn if the Streamer is actually enabled. Now, the users of the Streamer API are expected to check that they do have a LeafTxn and only use the Streamer if so. Additionally, this commit correctly populates `HasConcurrency` field for the local flows even when the query might be distributed. The fix is needed since the physical planning decision to distribute the query or not is finalized after we decide which txn to use for the flow, which is too late. Thus, whenever the Streamer is enabled and we find an index join in the plan, we will make sure to use the LeafTxn (this was already the case if the plan ended up being distributed). Release note: None 76716: tenantsettings: delete overrides when removing tenant r=RaduBerinde a=RaduBerinde Release note: None Co-authored-by: Jane Xing <[email protected]> Co-authored-by: Ben Bardin <[email protected]> Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Shiranka Miskin <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Radu Berinde <[email protected]>
- Loading branch information
Showing
32 changed files
with
1,048 additions
and
246 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
build/teamcity/cockroach/ci/builds/docker-fsnotify/BUILD.bazel
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euo pipefail | ||
|
||
dir="$(dirname $(dirname $(dirname $(dirname $(dirname "${0}")))))" | ||
source "$dir/teamcity-support.sh" | ||
|
||
tc_prepare | ||
|
||
tc_start_block "Run docker image tests" | ||
|
||
bazel run \ | ||
//pkg/testutils/docker:docker_test \ | ||
--config=crosslinux --config=test \ | ||
--test_timeout=3000 | ||
|
||
tc_end_block "Run docker image tests" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.