dev: various improvements to --cross compilation
#76320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Whoops, forgot to update the tests, that's my bad. |
rickystewart
force-pushed
the
crossfixes
branch
from
c22c38b to
4f050e6
Compare
rail
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
1. We bind-mount an empty file over `.bazelrc.user` so that user configuration doesn't interfere with or break cross builds. 2. Add a new `whereis` executable. It's basically just `realpath` except portable. 3. Update how `dev cache` finds the location of the `bazel-remote` binary: now we use `bazel run --run_under=whereis`, which doesn't require doing any funny stuff with `cquery`. 4. Allow cross-building `cmake` and `go_test` targets, using `realpath` to find where test and binary targets are placed. Closes cockroachdb#76094. Closes cockroachdb#76260. Release note: None
rickystewart
force-pushed
the
crossfixes
branch
from
4f050e6 to
6d18cb8
Compare
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.bazelrc.userso that userconfiguration doesn't interfere with or break cross builds.
whereisexecutable. It's basically justrealpathexceptportable.
dev cachefinds the location of thebazel-remotebinary: now we use
bazel run --run_under=whereis, which doesn'trequire doing any funny stuff with
cquery.cmakeandgo_testtargets, usingrealpathto find where test and binary targets are placed.
Closes #76094.
Closes #76260.
Release note: None