Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: recommendation to put dev configuration in .bazelrc.user file conflicts with cross builds #76094

Closed
rickystewart opened this issue Feb 4, 2022 · 1 comment · Fixed by #76320
Closed

dev: recommendation to put dev configuration in .bazelrc.user file conflicts with cross builds #76094

rickystewart opened this issue Feb 4, 2022 · 1 comment · Fixed by #76320
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

Generally this file will contain configuration that we don't want for a cross build.

Epic CRDB-8036
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Feb 4, 2022
@rickystewart rickystewart changed the title dev: before cross builds, temporarily move the .bazelrc.user file dev: recommendation to put dev configuration in .bazelrc.user file conflicts with cross builds Feb 7, 2022
@ajwerner
Copy link
Contributor

ajwerner commented Feb 7, 2022

Let's just have dev builder/dev build --cross bind mount an empty file over the .bazelrc.user.

rickystewart added a commit to rickystewart/cockroach that referenced this issue Feb 9, 2022
@rickystewart
dev: various improvements to --cross compilation
c22c38b 
1. We bind-mount an empty file over `.bazelrc.user` so that user
   configuration doesn't interfere with or break cross builds.
2. Add a new `whereis` executable. It's basically just `realpath` except
   portable.
3. Update how `dev cache` finds the location of the `bazel-remote`
   binary: now we use `bazel run --run_under=whereis`, which doesn't
   require doing any funny stuff with `cquery`.
4. Allow cross-building `cmake` and `go_test` targets, using `realpath`
   to find where test and binary targets are placed.

Closes cockroachdb#76094.
Closes cockroachdb#76260.

Release note: None
@rickystewart rickystewart mentioned this issue Feb 9, 2022
Merged
rickystewart added a commit to rickystewart/cockroach that referenced this issue Feb 9, 2022
@rickystewart
dev: various improvements to --cross compilation
4f050e6 
1. We bind-mount an empty file over `.bazelrc.user` so that user
   configuration doesn't interfere with or break cross builds.
2. Add a new `whereis` executable. It's basically just `realpath` except
   portable.
3. Update how `dev cache` finds the location of the `bazel-remote`
   binary: now we use `bazel run --run_under=whereis`, which doesn't
   require doing any funny stuff with `cquery`.
4. Allow cross-building `cmake` and `go_test` targets, using `realpath`
   to find where test and binary targets are placed.

Closes cockroachdb#76094.
Closes cockroachdb#76260.

Release note: None
craig bot pushed a commit that referenced this issue Feb 11, 2022
@dt @rickystewart
Merge #76274 #76320
657c0e1 
76274: backup: redact incremental storage URIs r=dt a=dt

Release note: none.

76320: dev: various improvements to `--cross` compilation r=rail a=rickystewart

1. We bind-mount an empty file over `.bazelrc.user` so that user
   configuration doesn't interfere with or break cross builds.
2. Add a new `whereis` executable. It's basically just `realpath` except
   portable.
3. Update how `dev cache` finds the location of the `bazel-remote`
   binary: now we use `bazel run --run_under=whereis`, which doesn't
   require doing any funny stuff with `cquery`.
4. Allow cross-building `cmake` and `go_test` targets, using `realpath`
   to find where test and binary targets are placed.

Closes #76094.
Closes #76260.

Release note: None

Co-authored-by: David Taylor <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in 6d18cb8 Feb 11, 2022
RajivTS pushed a commit to RajivTS/cockroach that referenced this issue Mar 6, 2022
@rickystewart @RajivTS
dev: various improvements to --cross compilation
fb00c0f 
1. We bind-mount an empty file over `.bazelrc.user` so that user
   configuration doesn't interfere with or break cross builds.
2. Add a new `whereis` executable. It's basically just `realpath` except
   portable.
3. Update how `dev cache` finds the location of the `bazel-remote`
   binary: now we use `bazel run --run_under=whereis`, which doesn't
   require doing any funny stuff with `cquery`.
4. Allow cross-building `cmake` and `go_test` targets, using `realpath`
   to find where test and binary targets are placed.

Closes cockroachdb#76094.
Closes cockroachdb#76260.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev: various improvements to --cross compilation rickystewart/cockroach
2 participants
@ajwerner @rickystewart