sql: fix call of FindIndexWithName
#75115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
In e89093f, we added `tableDesc.FindIndexWithName(name.String())`. However, `name.String()` can return a `EncodeRestrictedSQLIdent` version of the string. This fixes the call to use `string(name)`. I couldn't produce an error with this at the moment, mostly because there is some other check preventing it from happening from the combinations I've tried. Release note: None
postamar
approved these changes
Jan 20, 2022
|
haha, yeah it's easy to make. linter? yes but i'm not 100% on the conditions to make it trigger... bors r=postamar |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e89093f, we added
tableDesc.FindIndexWithName(name.String()). However,name.String()can return a
EncodeRestrictedSQLIdentversion of the string.This fixes the call to use
string(name).I couldn't produce an error with this at the moment, mostly because
there is some other check preventing it from happening from the
combinations I've tried.
Release note: None