ci: bring bazel ci up to parity with checks performed in old ci #74557
Conversation
|
This change is |
Up until this point, checking the release justification and whether all generated files were up to date was done only in GitHub CI rather than Bazel CI. We just copy those same checks into Bazel CI as well. Closes cockroachdb#68385. Release note: None
rickystewart
force-pushed
the
check_generated_code
branch
from
766eb63 to
5ffe06c
Compare
There was a problem hiding this comment.
Could you direct me to what's being changed in the build logs? ;) [I'm not familiar enough with the bazel and old ci checks to know where to look / what I should be looking for?] Thanks!
A read of the code itself makes senses to me!
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rail)
There was a problem hiding this comment.
approving, since code itself makes sense to me
Reviewable status:
Sorry -- in the build configuration link I sent in that comment, everything is new. It's a fully new build configuration. |
|
bors r=rail,celiala |
|
Build succeeded: |
Up until this point, checking the release justification and whether all
generated files were up to date was done only in GitHub CI rather than
Bazel CI. We just copy those same checks into Bazel CI as well.
Closes #68385.
Release note: None