Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add bazel ensure generated code job for CI #68385

Closed
jlinder opened this issue Aug 3, 2021 · 0 comments · Fixed by #74557
Closed

ci: add bazel ensure generated code job for CI #68385

jlinder opened this issue Aug 3, 2021 · 0 comments · Fixed by #74557
Assignees
@rickystewart
Labels
A-ci Continuous Integration C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@jlinder
Copy link
Collaborator

jlinder commented Aug 3, 2021 •
edited by exalate-issue-sync bot
Loading

Dependent on #68382 .

Epic CRDB-8306
@jlinder jlinder added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-ci Continuous Integration T-dev-inf labels Aug 3, 2021
@rickystewart rickystewart mentioned this issue Jan 6, 2022
Merged
craig bot pushed a commit that referenced this issue Jan 7, 2022
@rickystewart
Merge #74557
40cbbfb 
74557: ci: bring bazel ci up to parity with checks performed in old ci r=rail,celiala a=rickystewart

Up until this point, checking the release justification and whether all
generated files were up to date was done only in GitHub CI rather than
Bazel CI. We just copy those same checks into Bazel CI as well.

Closes #68385.

Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in 5ffe06c Jan 7, 2022
@craig craig bot closed this as completed in #74557 Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickystewart rickystewart

Labels
A-ci Continuous Integration C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: bring bazel ci up to parity with checks performed in old ci rickystewart/cockroach
2 participants
@jlinder @rickystewart