Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlsmith: make sure we don't call ALTER DATABASE SURVIVE with invalid goal #74335

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

RichardJCai
Copy link
Contributor

@RichardJCai RichardJCai commented Dec 30, 2021

Previously we would erroneously call ALTER DATABASE SURVIVE with
SurvivalGoalDefault which was invalid.

Release note: None

Resolves #74327

… goal

Previously we would erroneously call ALTER DATABASE SURVIVE with
SurvivalGoalDefault which was invalid.

Release note: None
@RichardJCai RichardJCai requested review from mgartner and a team December 30, 2021 20:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@RichardJCai
Copy link
Contributor Author

Thanks!
bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented Dec 30, 2021

Build succeeded:

@craig craig bot merged commit 3471dc5 into cockroachdb:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal/sqlsmith: TestGenerateParse failed with "unknown survival goal: 0"
3 participants