Merge #74335

74335: sqlsmith: make sure we don't call ALTER DATABASE SURVIVE with invalid goal r=yuzefovich a=RichardJCai Previously we would erroneously call ALTER DATABASE SURVIVE with SurvivalGoalDefault which was invalid. Release note: None Resolves #74327 Co-authored-by: richardjcai <[email protected]>
cockroachdb · Dec 30, 2021 · 3471dc5 · 3471dc5
2 parents cc22c45 + 64bfd38
commit 3471dc5
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pkg/internal/sqlsmith/alter.go b/pkg/internal/sqlsmith/alter.go
@@ -462,8 +462,13 @@ func makeAlterDatabaseDropRegion(s *Smither) (tree.Statement, bool) {
 }
 
 func makeAlterSurvivalGoal(s *Smither) (tree.Statement, bool) {
-	const numSurvivalGoals = 3
-	randInt := rand.Intn(numSurvivalGoals)
+	const numSurvivalGoals = 2
+	// Only {1, 2} are valid values for SurvivalGoal.
+	// 1. SurvivalGoalRegionFailure
+	// 2. SurvivalGoalZoneFailure
+	//
+	// 0. SurvivalGoalDefault is not valid as a value to alter to.
+	randInt := rand.Intn(numSurvivalGoals) + 1
 	survivalGoal := tree.SurvivalGoal(randInt)
 
 	ast := &tree.AlterDatabaseSurvivalGoal{