Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: remove dependency on ticks from maybeDropMsgApp #74108

Merged

Conversation

nvanbenschoten
Copy link
Member

Related to #73838.

In d77bee9, we stopped ticking uninitialized replicas, so we can no longer use ticks as a proxy for the age of a replica in the escape hatch of maybeDropMsgApp. Instead, we now use the age of the replica directly. We hit the escape hatch for any replica that is older than 20s, which corresponds to the 100 ticks we used before.

@nvanbenschoten nvanbenschoten requested a review from tbg December 20, 2021 22:48
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner December 20, 2021 22:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Avoids the `context.Background` in `replicaMsgAppDropper.ShouldDrop`.
Related to cockroachdb#73838.

In d77bee9, we stopped ticking uninitialized replicas, so we can no longer use
ticks as a proxy for the age of a replica in the escape hatch of `maybeDropMsgApp`.
Instead, we now use the age of the replica directly. We hit the escape hatch for
any replica that is older than 20s, which corresponds to the 100 ticks we used
before.
@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/replCreationTime branch from c6612f1 to 625ee8b Compare December 21, 2021 03:23
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)

@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 22, 2021

Build succeeded:

@craig craig bot merged commit 2129c2c into cockroachdb:master Dec 22, 2021
@blathers-crl
Copy link

blathers-crl bot commented Dec 22, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 63dfc14 to blathers/backport-release-21.1-74108: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


error creating merge commit from 63dfc14 to blathers/backport-release-21.2-74108: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants