bazel: upgrade rules_foreign_cc to 0.7
#73819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
upgraderulesforeigncc
branch
from
84249e1 to
264493d
Compare
|
whoops, the |
rickystewart
force-pushed
the
upgraderulesforeigncc
branch
4 times, most recently
from
e8cdf20 to
7c2bcba
Compare
Also add `-fcommon` to compile flags for `krb5`. Closes cockroachdb#71306. Release note: None
rickystewart
force-pushed
the
upgraderulesforeigncc
branch
from
7c2bcba to
4b38472
Compare
rail
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rail)
|
bors r=rail |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
|
This might've broken bazel builds. Things work just fine in the commit before (and |
|
Getting rid of |
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Dec 17, 2021
This becomes necessary after cockroachdb#73819, which sets `--incompatible_enable_cc_toolchain_resolution` for builds. The problem is that this flag causes Bazel to ignore `--crosstool_top` in favor of what toolchain it selects via [toolchain resolution](https://docs.bazel.build/versions/main/toolchains.html#toolchain-resolution). Therefore we update `.bazelrc` to specify the `--platforms` instead of `--crosstool_top`, and add an appropriate `toolchain` in `build/toolchains`. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
73875: restoreccl: insert system.namespace entry for synthetic public schemas during restore r=dt a=RichardJCai Release note (bug fix): Previously during restore we wouldn't insert a system.namespace entry for synthetic public schemas. Resolves #73535 73942: sql: simplify inserts into database descs with empty schemas map r=RichardJCai a=RichardJCai Release note: None 73948: DOC-2096: Update diagrams.go to force scrolling on svg div blocks r=ericharmeling a=nickvigilante Release note: None 73982: bazel: expose `devdarwinx86_64` toolchain via `platform` rules r=irfansharif a=rickystewart This becomes necessary after #73819, which sets `--incompatible_enable_cc_toolchain_resolution` for builds. The problem is that this flag causes Bazel to ignore `--crosstool_top` in favor of what toolchain it selects via [toolchain resolution](https://docs.bazel.build/versions/main/toolchains.html#toolchain-resolution). Therefore we update `.bazelrc` to specify the `--platforms` instead of `--crosstool_top`, and add an appropriate `toolchain` in `build/toolchains`. Release note: None Co-authored-by: richardjcai <[email protected]> Co-authored-by: Nick Vigilante <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Dec 20, 2021
With `--incompatible_enable_cc_toolchain_resolution` set in cockroachdb#73819, now Bazel selects the appropriate toolchain for you. Bazel was selecting the `cross_linux_toolchain` when building for the host platform on Linux, resulting in link errors when trying to compile `stress` under `race`. We update the toolchains to instead require opting into the cross toolchains by defining `cockroach_cross=y`. Closes cockroachdb#73997. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
72992: util/log: fix redactability of logging tags r=abarganier a=knz Fixes #72905. Some time in the v21.2 cycle, the log entry preparation logic was refactored and a mistake was introduced: the logging tags were not any more subject to the redaction logic. The result was that redaction markers were missing in log tag values, and if a value had contained unbalanced redaction markers in a value string (say, as part of a SQL table key), it would have caused log file corruption and possibly a confidential data leak. This patch fixes that, by preparing the logging tags in the same way as the main message for each entry. Release note (cli change): A bug affecting the redactability of logging tags in output log entries has been fixed. This bug had been introduced in the v21.2 release. 73937: setting: introduce setting classes r=RaduBerinde a=RaduBerinde This commit introduces the three setting classes in the RFC (#73349): `SystemOnly`, `TenantReadOnly`, and `TenantWritable`. The `SystemOnly` class replaces the existing `WithSystemOnly()`. In this change we don't yet implement the advertised semantics. We mechanically use `TenantWritable` for all settings except those that were using `WithSystemOnly()` which use `SystemOnly`; this should not change any existing behavior. The classes will be revisited in a separate change, after we implement the semantics. Release note: None 73978: opt: fix like escape processing for span constraints r=cucaroach a=cucaroach Fixes: #44123 Previously no attempt was made to properly handle escape ('\\') sequence in like patterns being turned into constraints. Refactor code used to process like at runtime to generate a regexp and use that to properly handle index constraint generation. Release note (sql change): Escape character processing was missing from constraint span generation which resulted in incorrect results when doing escaped like lookups. 74102: sql: do not fetch virtual columns during backfill r=mgartner a=mgartner Fixes #73372 Release note (bug fix): A bug has been fixed that caused internal errors when altering the primary key of a table. The bug was only present if the table had a partial index with a predicate that referenced a virtual computed column. This bug was present since virtual computed columns were added in version 21.1.0. 74110: bazel: require setting `cockroach_cross=y` to opt into cross toolchains r=irfansharif a=rickystewart With `--incompatible_enable_cc_toolchain_resolution` set in #73819, now Bazel selects the appropriate toolchain for you. Bazel was selecting the `cross_linux_toolchain` when building for the host platform on Linux, resulting in link errors when trying to compile `stress` under `race`. We update the toolchains to instead require opting into the cross toolchains by defining `cockroach_cross=y`. Closes #73997. Release note: None 74111: bench/rttanalysis: allow roundtrips to be off by 1 r=ajwerner a=ajwerner If we don't have a range, let the currently estimate be wrong by 1. We mostly care about the ballpark and the growth rate. I'm sick of these flakes. Fixes #73884. Release note: None 74152: ci: don't delete `test.json.txt` after processing r=tbg a=rickystewart We've seen some issues where Bazel jobs are failing in `github-post` (#73841, #74013) with the following output: found outstanding output. Considering last test failed: It's hard to say what the problem is because these scripts haven't kept the `test.json.txt` in `artifacts`. Here I remove the logic to clean up the file so we can RC further instances of the problem. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Andrew Werner <[email protected]>
gustasva
pushed a commit
to gustasva/cockroach
that referenced
this pull request
Jan 4, 2022
This becomes necessary after cockroachdb#73819, which sets `--incompatible_enable_cc_toolchain_resolution` for builds. The problem is that this flag causes Bazel to ignore `--crosstool_top` in favor of what toolchain it selects via [toolchain resolution](https://docs.bazel.build/versions/main/toolchains.html#toolchain-resolution). Therefore we update `.bazelrc` to specify the `--platforms` instead of `--crosstool_top`, and add an appropriate `toolchain` in `build/toolchains`. Release note: None
gustasva
pushed a commit
to gustasva/cockroach
that referenced
this pull request
Jan 4, 2022
With `--incompatible_enable_cc_toolchain_resolution` set in cockroachdb#73819, now Bazel selects the appropriate toolchain for you. Bazel was selecting the `cross_linux_toolchain` when building for the host platform on Linux, resulting in link errors when trying to compile `stress` under `race`. We update the toolchains to instead require opting into the cross toolchains by defining `cockroach_cross=y`. Closes cockroachdb#73997. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
-fcommonto compile flags forkrb5.Closes #71306.
Release note: None