bench/rttanalysis: allow roundtrips to be off by 1 #74111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
chengxiong-ruan
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @RichardJCai)
rafiss
approved these changes
Dec 21, 2021
| @@ -319,7 +319,9 @@ func (b benchmarkExpectations) find(name string) (benchmarkExpectation, bool) { | |||
| } | |||
|
|
|||
| func (e benchmarkExpectation) matches(roundTrips int) bool { | |||
| return e.min <= roundTrips && roundTrips <= e.max | |||
| return (e.min <= roundTrips && roundTrips <= e.max) || | |||
| e.min == e.max && | |||
There was a problem hiding this comment.
would
(e.min <= roundTrips && roundTrips <= e.max) || (e.min == e.max && (roundTrips == e.min-1 || roundTrips == e.min+1))
be even more clear?
There was a problem hiding this comment.
I unwrapped it one level and added commentary
If we don't have a range, let the currently estimate be wrong by 1. We mostly care about the ballpark and the growth rate. I'm sick of these flakes. Fixes cockroachdb#73884. Release note: None
ajwerner
force-pushed
the
ajwerner/deflake-rttanalysis
branch
from
f8283b3 to
0750472
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't have a range, let the currently estimate be wrong by 1.
We mostly care about the ballpark and the growth rate. I'm sick of
these flakes.
Fixes #73884.
Release note: None